Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isl + polylib + barvinok packages #23547

Closed
mkoeppe opened this issue Jul 29, 2017 · 26 comments
Closed

isl + polylib + barvinok packages #23547

mkoeppe opened this issue Jul 29, 2017 · 26 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 29, 2017

We package Sven Verdoolaege's barvinok package (for lattice points in polytopes etc). It has dependency isl and polylib..

Source codes at

Tarballs at


Remarks

  • pet is an optional dependency of barvinok and might be treated later on.

  • islpy provides Python bindings to isl and can be installed using pip. Though it will bring its own copy of isl... Documentation. The islpy package also claims to provide bindings for barvinok (haven't tested). To enable:

./sage -pip install --verbose --install-option --conf:'USE_BARVINOK=True' --install-option --conf:'USE_SHIPPED_ISL=False' --install-option --conf:'USE_SHIPPED_IMATH=False' islpy

CC: @videlec @mkoeppe @vinklein

Component: packages: optional

Author: Vincent Delecroix

Branch: 35989e9

Reviewer: Vincent Klein, Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/23547

@jdemeyer
Copy link

Replying to @mkoeppe:

It will bring its own copy of isl.

I don't think this is acceptable.

@videlec
Copy link
Contributor

videlec commented Aug 19, 2017

comment:3

I succeeded installing the barvinok program in my Sage installation doing

$ git clone git://repo.or.cz/barvinok.git
$ cd barvinok
$ sage -sh
(sage-sh) $ ./get_submodules.sh
(sage-sh) $ sh autogen.sh
(sage-sh) $ ./configure NTL_GMP_LIP=on --prefix=$SAGE_LOCAL --with-gmp-prefix=$SAGE_LOCAL --with-ntl-prefix=$SAGE_LOCAL
(sage-sh) $ make
(sage-sh) $ make install

I think that for cleaner packaging all submodules (isl, pet, polylib) should actually be independent packages.

@videlec

This comment has been minimized.

@videlec

This comment has been minimized.

@videlec

This comment has been minimized.

@videlec
Copy link
Contributor

videlec commented Nov 13, 2018

Author: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Nov 13, 2018

Commit: 82f0f8a

@videlec
Copy link
Contributor

videlec commented Nov 13, 2018

comment:7

With the current branch at 82f0f8afd6 I do obtain compilation errors. I might have done something wrong. Problem discussed on isl-development mailing list.


New commits:

82f0f8a23547: package isl+polylib+barvinok

@videlec
Copy link
Contributor

videlec commented Nov 13, 2018

Branch: u/vdelecroix/23547

@videlec

This comment has been minimized.

@videlec

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

89c76dd23547: package isl+polylib+barvinok

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Changed commit from 82f0f8a to 89c76dd

@videlec
Copy link
Contributor

videlec commented Nov 16, 2018

comment:11

The three spkg-check does pass on my computer... more testing needed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4984d3923547: package isl+polylib+barvinok

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Changed commit from 89c76dd to 4984d39

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

35989e923547: package isl+polylib+barvinok

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Changed commit from 4984d39 to 35989e9

@videlec videlec changed the title Add isl and barvinok packages isl + polylib + barvinok packages Nov 16, 2018
@vinklein
Copy link
Mannequin

vinklein mannequin commented Nov 21, 2018

comment:16

Ticket installed and compiled on OSX.

The output of barvinok tests is pretty strange with repetition of 'o' and '.' characters.

$ sage -f -c barvinok
...
[barvinok-0.41.1] ./tests/supporting1 --specialization=df --primal --index=10 ok
[barvinok-0.41.1] ./tests/supporting1 --specialization=todd --primal --index=10 ok
[barvinok-0.41.1] ./tests/supporting2 --specialization=random --index=10o.......ooooooooooooooooooooooooo ok................................
[barvinok-0.41.1] ./tests/supporting2 --specialization=bf --index=10oooooooooooooooooooooooooooooooooooooooooo
[barvinok-0.41.1]  ok
[barvinok-0.41.1] ./tests/supporting2 --specialization=df --index=10./tests/ehrhart/g13.in
[barvinok-0.41.1]  ok
[barvinok-0.41.1] ./tests/supporting2 --specialization=todd --index=10..........ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo
[barvinok-0.41.1]  ok
...

@vinklein
Copy link
Mannequin

vinklein mannequin commented Nov 21, 2018

comment:17

Checks tests are successful for the three packages on OSX.

@seblabbe
Copy link
Contributor

Reviewer: Vincent Klein, Sébastien Labbé

@seblabbe
Copy link
Contributor

comment:18

Installation tested on Ubuntu 16.04. sage -f -c barvinok works. Positive review.

@videlec
Copy link
Contributor

videlec commented Nov 22, 2018

comment:19

Bravo! Merci!

@vbraun
Copy link
Member

vbraun commented Nov 23, 2018

Changed branch from u/vdelecroix/23547 to 35989e9

@Konrad127123
Copy link

comment:21

Note that isl>=0.20 breaks compiling of gcc (fix in #26735), so this presumably makes make isl && make gcc fail, even on computers with system isl<0.20. (I have system isl=0.20 already, so I can't test that this is the case.)

@Konrad127123
Copy link

Changed commit from 35989e9 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants