Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface cases function with SymPy's piecewise #23923

Closed
rwst opened this issue Sep 23, 2017 · 16 comments
Closed

Interface cases function with SymPy's piecewise #23923

rwst opened this issue Sep 23, 2017 · 16 comments

Comments

@rwst
Copy link

rwst commented Sep 23, 2017

In #20191 the cases function is introduced. This ticket should interface it with SymPy's piecewise (both directions) and test with:

        sage: _ = var('y, z')
        sage: (x^y - z).integrate(y)
        -y*z + x^y/log(x)
        sage: (x^y - z).integrate(y, algorithm="sympy")  # see Trac #14694
        -y*z + cases(((log(x) == 0, y), (1, x^y/log(x))))

Depends on #20191
Depends on #23990
Depends on #24006

CC: @mforets @EmmanuelCharpentier

Component: interfaces

Author: Ralf Stephan

Branch/Commit: b261ec3

Reviewer: Emmanuel Charpentier

Issue created by migration from https://trac.sagemath.org/ticket/23923

@rwst rwst added this to the sage-8.1 milestone Sep 23, 2017
@rwst
Copy link
Author

rwst commented Oct 8, 2017

Changed dependencies from #20191 to #20191, #23990

@rwst
Copy link
Author

rwst commented Oct 8, 2017

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Oct 9, 2017

Commit: ea10ee7

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Oct 9, 2017

New commits:

ea10ee723923: interface cases() with SymPy

@rwst
Copy link
Author

rwst commented Oct 17, 2017

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Changed commit from ea10ee7 to b80d98c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

b80d98c23923: fix typo

@rwst
Copy link
Author

rwst commented Oct 17, 2017

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented Oct 17, 2017

Changed dependencies from #20191, #23990 to #20191, #23990, #24006

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Oct 17, 2017

comment:7

On top of 8.1beta7+#24026 + #24006(dependency) + #23990(dependency) + #23923(present patch), one permanent failure :

sage -t --long src/sage/symbolic/integration/integral.py
**********************************************************************
File "src/sage/symbolic/integration/integral.py", line 508, in sage.symbolic.int
egration.integral.integrate
Failed example:
    (x^y - z).integrate(y, algorithm="sympy")  # see Trac #14694
Expected:
    Traceback (most recent call last):
    ...
    AttributeError: 'ExprCondPair' object has no attribute '_sage_'
Got:
    -y*z + cases(((log(x) == 0, y), (1, x^y/log(x))))
**********************************************************************
1 item had failures:
   1 of 126 in sage.symbolic.integration.integral.integrate
    [169 tests, 1 failure, 53.41 s]

==>needs_work. Probably a booboo, though...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Changed commit from b80d98c to b261ec3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

b261ec323923: fix doctest

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Oct 17, 2017

comment:10

On top of 8.1beta8+#24026 + #24006(dependency) + #23990(dependency) + #23923(present patch), passes ptestlong with no error whatsoever.

==>positive_review

Notes :

  • I rebased the test on the hust-issued 8.1.beta8
  • I have kept Upgrade R to 3.4.2 #24026 (which needs_review, BTW...) because removing it entails recompiling R (which is slow) and reinstall 442 R packages, (which is slower...).

@rwst
Copy link
Author

rwst commented Oct 18, 2017

Reviewer: Emmanuel Charpentier

@rwst
Copy link
Author

rwst commented Oct 18, 2017

comment:11

Thanks. I've added your name, hope it's not impolite.

@vbraun
Copy link
Member

vbraun commented Oct 30, 2017

Changed branch from u/rws/23923 to b261ec3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants