-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pynac-0.7.15 #24497
Comments
This comment has been minimized.
This comment has been minimized.
Branch: u/rws/upgrade_to_pynac_0_7_15 |
Commit: |
Author: Ralf Stephan |
comment:5
All tests pass on quasar. |
comment:6
The only thing I'm not sure about is the change in |
comment:7
The former result changes quite a bit, I think because small changes are enlarged by substitution into a polynomial. I tried to preserve the assumed spirit of the test, i.e. a nonzero real part of the result, but to make it more robust. Of course I may be wrong with my assumptions. |
comment:8
Passes tests on sardonis (ppc64le) too. |
Changed branch from u/rws/upgrade_to_pynac_0_7_15 to u/jdemeyer/upgrade_to_pynac_0_7_15 |
comment:10
Replying to @rwst:
I kept the test but adjusted the answer. Does that work for you? New commits:
|
comment:11
Replying to @jdemeyer:
Yes. |
Reviewer: Jeroen Demeyer |
comment:13
Thanks for the review. |
comment:14
On Ubuntu 16 32-bit:
|
comment:15
So you see how useless the test is in this form. I'm replacing it with my version. |
Changed branch from u/jdemeyer/upgrade_to_pynac_0_7_15 to u/rws/24497 |
comment:17
It's just a test. New commits:
|
comment:18
Replying to @rwst:
Not useless. We just need to increase the tolerance. |
Changed branch from u/rws/24497 to u/rws/24497-1 |
New commits:
|
Changed branch from u/rws/24497-1 to |
In 0.7.15:
infinity.info()
,function.info()
,power.info(negative)
symbol.real/imag_part()
sage.rings
constant.is_nonzero()
(Doctest: Expression.is_positive/negative fixed #18630)info(even)
(Even assumption / variable domain / query #24351)info(nonzero)
info(rational)
https://github.com/pynac/pynac/releases/download/pynac-0.7.15/pynac-0.7.15.tar.bz2
CC: @kiwifb
Component: packages: standard
Author: Ralf Stephan
Branch/Commit:
d085587
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/24497
The text was updated successfully, but these errors were encountered: