Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate is_RealNumber, is_AlgebraicNumber, is_RealIntervalFieldElement, ... #24525

Closed
videlec opened this issue Jan 11, 2018 · 4 comments · Fixed by #38128
Closed

deprecate is_RealNumber, is_AlgebraicNumber, is_RealIntervalFieldElement, ... #24525

videlec opened this issue Jan 11, 2018 · 4 comments · Fixed by #38128
Labels
c: basic arithmetic good first issue p: major / 3 t: enhancement
Milestone
sage-10.4

Comments

@videlec
Copy link
Contributor

videlec commented Jan 11, 2018

We deprecate is_RealNumber, is_ComplexNumber, is_AlgebraicNumber, is_RealIntervalFieldElement, ...

git grep 'is_.*Number(' and git grep -E 'is_(Real|Complex).*Element[(]' only shows a small number of uses.

We replace all uses either by

  • isinstance tests with the element class (if the module providing it is imported already) or
  • isinstance tests of the parent with an abc defined in sage.rings.abc

See also:

Depends on #32566

CC: @tscrim

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/24525
@videlec videlec added this to the sage-8.2 milestone Jan 11, 2018
@videlec

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 2, 2021

comment:2

#32610 takes care of is_RealField

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 3, 2021

Changed dependencies from #24524 to #32566

@mkoeppe mkoeppe modified the milestones: sage-8.2, sage-9.5 Oct 3, 2021
@mkoeppe mkoeppe changed the title deprecate is_RealField / is_RealNumber deprecate is_RealNumber, is_AlgebraicNumber, is_RealIntervalFieldElement, ... Oct 3, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@videlec videlec mentioned this issue Dec 29, 2022
Open
@mkoeppe mkoeppe modified the milestones: sage-10.0, sage-10.1 Apr 30, 2023
@mkoeppe mkoeppe removed this from the sage-10.1 milestone Aug 7, 2023
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 10, 2024
sagemathgh-38128: Deprecate is_AlgebraicNumber, is_AlgebraicReal,…
524fcbd 
… `is_ComplexDoubleElement`, `is_ComplexIntervalFieldElement`, `is_ComplexNumber`, `is_FractionField`, `is_FractionFieldElement`, `is_Integer`, `is_IntegerMod`, `is_IntegerRing`, `is_Rational`, `is_RationalField`, `is_RealDoubleElement`, `is_RealIntervalField`, `is_RealIntervalFieldElement`, `is_RealNumber`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#24525

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38128
Reported by: Matthias Köppe
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 16, 2024
sagemathgh-38128: Deprecate is_AlgebraicNumber, is_AlgebraicReal,…
98a2b16 
… `is_ComplexDoubleElement`, `is_ComplexIntervalFieldElement`, `is_ComplexNumber`, `is_FractionField`, `is_FractionFieldElement`, `is_Integer`, `is_IntegerMod`, `is_IntegerRing`, `is_Rational`, `is_RationalField`, `is_RealDoubleElement`, `is_RealIntervalField`, `is_RealIntervalFieldElement`, `is_RealNumber`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#24525

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38128
Reported by: Matthias Köppe
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 16, 2024
sagemathgh-38128: Deprecate is_AlgebraicNumber, is_AlgebraicReal,…
80e07f2 
… `is_ComplexDoubleElement`, `is_ComplexIntervalFieldElement`, `is_ComplexNumber`, `is_FractionField`, `is_FractionFieldElement`, `is_Integer`, `is_IntegerMod`, `is_IntegerRing`, `is_Rational`, `is_RationalField`, `is_RealDoubleElement`, `is_RealIntervalField`, `is_RealIntervalFieldElement`, `is_RealNumber`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#24525

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38128
Reported by: Matthias Köppe
Reviewer(s): gmou3
@vbraun vbraun closed this as completed in 3cc13a2 Jun 22, 2024
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: basic arithmetic good first issue p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.4
2 participants
@videlec @mkoeppe