Move most important attributes of FaceIterator to a structure.

[kliem]

This ticket is part of a series of tickets to parallelize the f-vector for polyhedra.

Python classes may not be accessed in nogil. To access important attributes of the class FaceIterator, we move those attributes to a structure, which can be accessed in nogil.

Along the way, the ticket simplifies some doctests that define cython functions.

CC: @jplab @LaisRast

Component: geometry

Keywords: combinatorial polyhedron, face iterator, f-vector

Author: Jonathan Kliem

Branch/Commit: 142d3a8

Reviewer: Jean-Philippe Labbé, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28894

[kliem]

New commits:

2582549

important attributes of iterator in structure

[kliem]

Commit: 2582549

[kliem]

Branch: public/28894

[kliem]

Changed commit from 2582549 to db31390

[kliem]

Changed branch from public/28894 to public/28894-reb

[kliem]

New commits:

db31390

important attributes of iterator in structure

[embray]

comment:4

Ticket retargeted after milestone closed

[kliem]

New commits:

c3e2cb7	important attributes of iterator in structure
3e7f7f8	applied changes to simplicity and simpliciality

[kliem]

Changed commit from db31390 to 3e7f7f8

[kliem]

Changed branch from public/28894-reb to public/28894-reb2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8d933c3	important attributes of iterator in structure
c0c9a31	applied changes to simplicity and simpliciality

[sagetrac-git]

Changed commit from 3e7f7f8 to c0c9a31

[kliem]

comment:7

Apply failed.

[kliem]

New commits:

a58ffbe	important attributes of iterator in structure
6d0644a	simplification of doctests

[kliem]

Changed branch from public/28894-reb2 to public/28894-reb3

[kliem]

Changed commit from c0c9a31 to 6d0644a

[mkoeppe]

comment:9

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

[kliem]

New commits:

41eb697	important attributes of iterator in structure
56dcddf	src/simplification of doctests

[kliem]

Changed commit from 6d0644a to 56dcddf

[kliem]

Changed branch from public/28894-reb3 to public/28894-reb4

[kliem]

Changed commit from 56dcddf to 53fd2a2

[kliem]

Changed branch from public/28894-reb4 to public/28894-reb5

[kliem]

New commits:

0c44221	important attributes of iterator in structure
efb0bd3	src/simplification of doctests
53fd2a2	fixed failing doctest

[jplab]

Reviewer: Jean-Philippe Labbé

[jplab]

comment:12

Looks good to me.

[kliem]

comment:13

Thank you.

[sagetrac-git]

Changed commit from 53fd2a2 to 142d3a8

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

142d3a8

bad alignment causing bug noticed in #28982

[kliem]

comment:15

In the dual case the n_atoms/n_coatoms where initialized wrong in the face iterator. This made doctests in #28982 fail.

[fchapoton]

Changed reviewer from Jean-Philippe Labbé to Jean-Philippe Labbé, Frédéric chapoton

[fchapoton]

comment:16

back to positive

[fchapoton]

Changed reviewer from Jean-Philippe Labbé, Frédéric chapoton to Jean-Philippe Labbé, Frédéric Chapoton

[kliem]

comment:18

Thank you.

[vbraun]

Changed branch from public/28894-reb5 to 142d3a8