Improve face generator of polyhedra by exposing FaceIterator class

[kliem]

Currently, the face generator of polyhedra is a wrapper of the FaceIterator class, which is intended for combinatorial polyhedra.

However, it takes only little effort to modify this to return a PolyhedronFace instead of a CombinatorialFace on next. The class FaceIterator has the advantage that it exposes extra features of FaceIterator. Currently, there is only the possibility of ignoring sub- or supfaces, but there might be more features added later.

It also simplifies it a lot for the user to obtain a PolyhedronFace from FaceIterator as the needed function is not exactly easy to find.

Follow up:

• Use FaceIterator to obtain the meet of (some) vertices or the join of (some) facets.

This is motivated by https://ask.sagemath.org/question/34485/what-is-the-most-efficient-way-to-look-up-a-face-in-the-face-lattice-of-a-polyhedron/#50965

Depends on #28894

CC: @jplab @LaisRast @videlec

Component: geometry

Keywords: polyhedra, face iterator

Author: Jonathan Kliem

Branch/Commit: 3ba34fd

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29654

[kliem]

New commits:

b4474b0

a face iterator subclass that yield PolyhedronFace

[kliem]

Commit: b4474b0

[kliem]

Branch: public/29654

[kliem]

Changed commit from b4474b0 to 82fe300

[kliem]

New commits:

b4dca3e	a face iterator subclass that yield PolyhedronFace
f5b7e22	representation like Polyhedron_base
3e5407c	account for FaceIterator -> FaceIterator_base
82fe300	documentation

[kliem]

Changed branch from public/29654 to public/29654-reb

[sagetrac-git]

Changed commit from 82fe300 to 2f274e9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2f274e9

coverage and small improvement

[kliem]

New commits:

2f274e9

coverage and small improvement

---

New commits:

2f274e9

coverage and small improvement

[kliem]

Dependencies: #28894

[kliem]

comment:5

There was a merge conflict with #28894, so I rebased.

---

New commits:

0c44221	important attributes of iterator in structure
efb0bd3	src/simplification of doctests
53fd2a2	fixed failing doctest
a6d2b2d	a face iterator subclass that yield PolyhedronFace
1476675	representation like Polyhedron_base
47fc7cd	account for FaceIterator -> FaceIterator_base
295039a	documentation
d36da4a	coverage and small improvement

[kliem]

Changed branch from public/29654-reb to public/29654-reb2

[kliem]

Changed commit from 2f274e9 to d36da4a

[mkoeppe]

comment:6

Needs rebase

[kliem]

comment:7

Somebody fixed a docstring syntax mistake of mine.

[kliem]

comment:8

I also noticed that I had most of the documentation in the base class, which I think it is bad design, because it is not exposed.

So I moved it to FaceIterator, because this one is exposed and is the most basic case of FaceIterator_base.

---

New commits:

3f92d2d	fixed merge conflict
3ba34fd	move documenation to exposed class

[kliem]

Changed commit from d36da4a to 3ba34fd

[kliem]

Changed branch from public/29654-reb2 to public/29654-reb3

[mkoeppe]

Reviewer: Matthias Koeppe

[mkoeppe]

comment:9

This looks like a nice improvement.

[kliem]

comment:10

Thank you.

[vbraun]

Changed branch from public/29654-reb3 to 3ba34fd