Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement incidence matrix for combinatorial polyhedron #29112

Closed
kliem opened this issue Jan 30, 2020 · 6 comments
Closed

Implement incidence matrix for combinatorial polyhedron #29112

kliem opened this issue Jan 30, 2020 · 6 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@kliem
Copy link
Contributor

kliem commented Jan 30, 2020

We implement the incidence matrix for CombinatorialPolyhedron. This is just exposure of the already present combinatorial data in a nice presentation for the user.

CC: @jplab @LaisRast

Component: geometry

Keywords: incidence matrix, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 6ee9276

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/29112
@kliem kliem added this to the sage-9.1 milestone Jan 30, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 31, 2020

comment:2

Forgot to set the branch.

New commits:

6ee9276implement incidence matrix for combinatorial polyhedron

@kliem
Copy link
Contributor Author

kliem commented Jan 31, 2020

Commit: 6ee9276

@kliem
Copy link
Contributor Author

kliem commented Jan 31, 2020

Branch: public/29122

@LaisRast
Copy link

Reviewer: Laith Rastanawi

@LaisRast
Copy link

comment:3

It looks good to me.
(pyflakes warnings are to be handled in #28880)

@vbraun
Copy link
Member

vbraun commented Feb 10, 2020

Changed branch from public/29122 to 6ee9276

@vbraun vbraun closed this as completed in 8b9e6bb Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @kliem @LaisRast