-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spkg-configure.m4 for ppl #29454
Comments
Commit: |
Author: Michael Orlitzky |
Branch: u/mjo/ticket/29454 |
comment:2
On conda, the package is I get the following error,
|
comment:3
Hm... it's passing -lppl to the link command, is your conda library path on that command-line somewhere? |
Changed branch from u/mjo/ticket/29454 to u/mkoeppe/ticket/29454 |
comment:6
Looks like New commits:
|
comment:7
Something wrong with their m4 macro, then? They stick the |
comment:8
Yes, that's wrong |
comment:9
See if this works? I've hacked their macro to loop through the output of New commits:
|
Changed branch from u/mkoeppe/ticket/29454 to u/mjo/ticket/29454 |
comment:10
Works for me. Can you add |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:12
Yeah, sorry, I forgot. |
Reviewer: Isuru Fernando |
comment:14
Upstream report for posterity: https://www.cs.unipr.it/mantis/view.php?id=2638 |
Upstream: Reported upstream. No feedback yet. |
comment:25
See https://src.fedoraproject.org/rpms/ppl/blob/master/f/ppl.spec on how Fedora builds its ppl packages. In particular:
|
comment:26
That should be installing their copy of ppl.hh that "selects the appropriate header file depending on the architecture for which the compiler is compiling." |
comment:27
Fedora 30 has packages ppl and ppl-devel, and ppl-config in one of them.
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:29
Thanks, I force-pushed over that last commit to add ppl-devel on Fedora. Maybe that solves the header problem. |
comment:30
Testing at https://github.com/mkoeppe/sage/actions/runs/70615046 |
comment:31
fedora needs more work, see for example https://github.com/mkoeppe/sage/suites/572702630/artifacts/3888966
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:33
One more try! That's another thing I'll have to report upstream if the new commit fixes the issue. |
comment:34
Thanks for setting up this test infrastructure, by the way. I occasionally feel personally attacked by github, but it's ultimately better to find and fix these problems early on. |
comment:35
Looking good now. (Tests at https://github.com/mkoeppe/sage/actions/runs/71360666) |
Changed reviewer from Isuru Fernando to Isuru Fernando, Matthias Koeppe |
Changed branch from u/mjo/ticket/29454 to |
Changed commit from |
comment:37
there is a (hopefully innocent) no-op + [ # Some of its dependencies are installed as SPKGs, so install the
+ # ppl SPKG as well.
+ sage_spkg_install_ppl=yes there is actually no need to set this var to |
comment:38
Regarding homebrew: this suggests using homebrew to install ppl, but Sage then doesn't allow that:
And this is because Sage doesn't allow
Is this because of the doctest failures which have been fixed at #29317? That is, can we use an unpatched |
comment:39
Replying to @dimpase:
I've made this (apparently harmless in all cases) mistake a few times by copy/pasting something that never worked to begin with. I left myself a note to go back and delete them all. |
comment:40
Replying to @jhpalmieri:
We do use unpatched (to some extent) glpk on various Linux distos, I don't see why Homebrew is special in this sense. By the way, did you try submitting a Homebrew issue to fix this? I recently managed to talk them into fixing an annoying thing about their gettext package. Nothing prevents you from installing glkp on Homebrew and using it regardless, |
comment:41
I see this when I use the system's ppl:
|
comment:42
probably noone tested with |
comment:43
I've opened #29591. |
This is a C++ library with no pkg-config file, but at least upstream provides an m4 macro to detect itself.
Upstream: Reported upstream. No feedback yet.
CC: @dimpase @embray @mkoeppe @kiwifb
Component: build: configure
Author: Michael Orlitzky
Branch:
fa6e0d9
Reviewer: Isuru Fernando, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/29454
The text was updated successfully, but these errors were encountered: