Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gcc to 10.3 (latest 10.x) #29703

Closed
mkoeppe opened this issue May 17, 2020 · 26 comments
Closed

Upgrade gcc to 10.3 (latest 10.x) #29703

mkoeppe opened this issue May 17, 2020 · 26 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 17, 2020

Follow-up from #29674 (fedora-32: If gcc 10 is found, install gcc spkg; fix building gcc (9.2.0) spkg with gcc 10). As noted there, on many systems, building --without-system-gcc fails.

gcc 10.3 was released 2021-04-08.

Potentially helpful for fedora-34 (released end of April 2021), which uses gcc 11, which our configure script rejects.

We also need a newer gcc to provide a gfortran for macOS builds (homebrew-macos-minimal, macos-nohomebrew) on Big Sur

homebrew:

macports:

See also:

CC: @zlscherr @jhpalmieri @dimpase @vbraun @kiwifb @enriqueartal

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 22c050a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29703

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 17, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Upgrade gcc to latest 9.x, fix --without-system-gcc builds Upgrade gcc to latest 10.x, fix --without-system-gcc builds Mar 16, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:6

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Upgrade gcc to latest 10.x, fix --without-system-gcc builds Upgrade gcc to 10.3 (latest 10.x), fix --without-system-gcc builds May 3, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2021

Commit: 22c050a

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2021

New commits:

22c050abuild/pkgs/gcc: Update to 10.3.0

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.3 May 3, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 6, 2021

comment:14

local build (with make gcc) fails on homebrew-macos

In file included from ../../src/gcc/gengtype.c:26:
../../src/gcc/system.h:544:20: error: conflicting declaration of C function 'const char* strsignal(int)'
  544 | extern const char *strsignal (int);
      |                    ^~~~~~~~~
In file included from /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/tmp/sage/build/gcc-10.3.0/gcc-build/prev-x86_64-apple-darwin19.6.0/libstdc++-v3/include/cstring:42,
                 from ../../src/gcc/system.h:235,
                 from ../../src/gcc/gengtype.c:26:
/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/string.h:134:7: note: previous declaration 'char* strsignal(int)'
  134 | char *strsignal(int __sig);
      |       ^~~~~~~~~
make[6]: *** [build/sort.o] Error 1
make[6]: *** [build/gengtype-parse.o] Error 1
make[6]: *** [build/gengenrtl.o] Error 1

But it did not work with the previous version either.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 6, 2021

comment:15

Looking fine for Linux and macOS (-minimal configurations where we build gfortran from the spkg) - https://github.com/mkoeppe/sage/runs/2494424419

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 6, 2021

comment:17

However, this upgrade does NOT fix #31624 (fedora-34-standard: eclib, singular build failures with system ntl). https://github.com/mkoeppe/sage/runs/2494425736

So there is no urgency to this upgrade.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 May 6, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 6, 2021

comment:18

... unless this helps with Big Sur?

@dimpase
Copy link
Member

dimpase commented May 6, 2021

comment:19

let's not duplicate the efforts of Homebree and Conda...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 7, 2021

comment:20

In any case... needs review

@dimpase
Copy link
Member

dimpase commented May 8, 2021

comment:21

good to get rid of patches.

@mkoeppe mkoeppe changed the title Upgrade gcc to 10.3 (latest 10.x), fix --without-system-gcc builds Upgrade gcc to 10.3 (latest 10.x) May 8, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 8, 2021

comment:23

Thanks

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 10, 2021

comment:24

Replying to @dimpase:

let's not duplicate the efforts of Homebree and Conda...

And here we go. Our Sage 9.3 does not build with Big Sur / Homebrew - as just reported https://groups.google.com/g/sage-devel/c/Yut08rvqgvg/m/9uD4W6hFBAAJ

@dimpase
Copy link
Member

dimpase commented May 10, 2021

comment:26

we need a proper formula for building Sage using Homebrew, then we can pin versions of dependencies etc.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 10, 2021

comment:27

Downstream packaging is traditionally considered not part of the upstream project. But if you want to work on it, this would certainly be valuable to some mac users. But lots of packages are missing on homebrew, so you'd be ... duplicating packaging work that has already been done in conda-forge.

@vbraun
Copy link
Member

vbraun commented May 27, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants