Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gcc to 9.3 #29827

Closed
mkoeppe opened this issue Jun 8, 2020 · 17 comments
Closed

Upgrade gcc to 9.3 #29827

mkoeppe opened this issue Jun 8, 2020 · 17 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 8, 2020

We upgrade gcc from 9.2 to 9.3

https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=9.3

part of #29703

tarball: see checksums.ini [upstream_url]

Previous update:

CC: @jhpalmieri @zlscherr

Component: packages: standard

Branch/Commit: u/mkoeppe/upgrade_gcc_to_9_3 @ d07ba7b

Issue created by migration from https://trac.sagemath.org/ticket/29827

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 8, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 8, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 8, 2020

Branch: u/mkoeppe/upgrade_gcc_to_9_3

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 8, 2020

New commits:

ff3bb3abuild/pkgs/gcc: Update to 9.3.0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 8, 2020

Commit: ff3bb3a

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9eb8b21build/pkgs/gcc: Update to 9.3.0
cd59612build/pkgs/gcc: Remove libsanitizer patches (upstreamed)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 2, 2021

Changed commit from ff3bb3a to cd59612

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 2, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 3, 2021

comment:7

Patches need updating

gfortran-9.3.0]   Applying patches from ../patches...
  [gfortran-9.3.0]   Applying ../patches/gcc-multilib-multiarch.patch
  [gfortran-9.3.0]   patching file gcc/config/i386/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/mips/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/rs6000/t-linux
  [gfortran-9.3.0]   Hunk #1 succeeded at 2 with fuzz 2.
  [gfortran-9.3.0]   patching file gcc/config/rs6000/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/s390/t-linux64
  [gfortran-9.3.0]   patching file gcc/config/sparc/t-linux64
  [gfortran-9.3.0]   Applying ../patches/homebrew-9.2.0-catalina.patch
  [gfortran-9.3.0]   patching file fixincludes/fixincl.x
  [gfortran-9.3.0]   Hunk #1 FAILED at 2.
  [gfortran-9.3.0]   Hunk #2 FAILED at 15.
  [gfortran-9.3.0]   Hunk #3 succeeded at 2686 (offset 50 lines).
  [gfortran-9.3.0]   Hunk #4 FAILED at 10388.
  [gfortran-9.3.0]   Hunk #5 succeeded at 10558 (offset 100 lines).
  [gfortran-9.3.0]   Hunk #6 succeeded at 11071 (offset 106 lines).
  [gfortran-9.3.0]   3 out of 6 hunks FAILED -- saving rejects to file fixincludes/fixincl.x.rej
  [gfortran-9.3.0]   patching file fixincludes/inclhack.def
  [gfortran-9.3.0]   Hunk #1 succeeded at 1325 (offset 27 lines).
  [gfortran-9.3.0]   Error applying '../patches/homebrew-9.2.0-catalina.patch'

https://github.com/mkoeppe/sage/runs/2017617134?check_suite_focus=true

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 3, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d07ba7bbuild/pkgs/gcc/patches: Remove

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 3, 2021

Changed commit from cd59612 to d07ba7b

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 16, 2021

comment:9

As @zlscherr reports in #31326, upgrading to gcc 9.3 does NOT fix the issues on macOS Big Sur.

homebrew:

Not sure if anyone has a backport to the GCC 9.x series

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 16, 2021

Changed author from Matthias Koeppe to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 16, 2021

comment:10

I had thought that staying for a while on the GCC 9.x series would be useful - given how many fixes were necessary in packages for the 10.x series, there may still be optional/experimental/user packages that cannot be built with GCC 10.

But it looks like this is not going anywhere, so let's move on and continue in #29703 with an upgrade to 10.x

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 16, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/615728756 to none

@mkoeppe mkoeppe removed this from the sage-9.3 milestone Mar 16, 2021
@jhpalmieri
Copy link
Member

comment:11

Sounds okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants