Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script packages should cd into the SPKG directory #29793

Closed
mkoeppe opened this issue Jun 4, 2020 · 18 comments
Closed

script packages should cd into the SPKG directory #29793

mkoeppe opened this issue Jun 4, 2020 · 18 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 4, 2020

This simplifies several spkg-install scripts and make script packages a bit more similar to normal packages.

This is a step towards #29386 (Install script packages via sage-spkg).

Depends on #29345

CC: @jhpalmieri @embray @orlitzky @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 72346ef

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/29793

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 4, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2020

Commit: df3f05e

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2020

Last 10 new commits:

fb475f3Trac #29345: replace a few obsolete "-a" tests with "-e".
305d8cfTrac #29345: replace a bash array with something portable.
d0dff56Trac #29345: replace a few uses of "source" with "."
5ac420bTrac #29345: fix some bashisms in sage-env's resolvelinks() function.
0a61795Trac #29345: don't force SHELL=bash any longer.
5db5318Trac #29345: remove "break" statements from AC_SEARCH_LIBS.
e810ad1Trac #29345: don't use sage's config.status for the lrcalc build.
93c9921Trac #29345: replace the function that populates the CVXOPT_* variables.
0e66a0aTrac #29345: add Dima's SPKG patches for ksh compatibility.
df3f05ebuild/make/Makefile.in [SCRIPT_PACKAGE_templ]: cd into the SPKG directory; adjust spkg-install scripts

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2020

comment:3

Branch is on top of #29345. There is only 1 new commit.

@orlitzky
Copy link
Contributor

orlitzky commented Jun 4, 2020

Reviewer: Michael Orlitzky

@orlitzky
Copy link
Contributor

orlitzky commented Jun 4, 2020

comment:4

LGTM but is there some documentation that says what the initial working directory of spkg-install should be? It shouldn't be an implementation detail.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2020

comment:5

Indeed I forgot to update the documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2020

Changed commit from df3f05e to 72346ef

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

72346efUpdate developer manual on script packages

@orlitzky
Copy link
Contributor

orlitzky commented Jun 4, 2020

comment:8

Even better.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2020

comment:9

Thank you!

@dimpase
Copy link
Member

dimpase commented Jun 15, 2020

comment:10

rebased over rebased #29345


Last 10 new commits:

ff63210Trac #29345: replace a bash array with something portable.
bb69c7eTrac #29345: replace a few uses of "source" with "."
c549738Trac #29345: fix some bashisms in sage-env's resolvelinks() function.
b445b6eTrac #29345: don't force SHELL=bash any longer.
18dd124Trac #29345: remove "break" statements from AC_SEARCH_LIBS.
6a5d73fTrac #29345: don't use sage's config.status for the lrcalc build.
3d8ba26Trac #29345: replace the function that populates the CVXOPT_* variables.
604657aTrac #29345: add Dima's SPKG patches for ksh compatibility.
493a7e2build/make/Makefile.in [SCRIPT_PACKAGE_templ]: cd into the SPKG directory; adjust spkg-install scripts
7a6cb81Update developer manual on script packages

@dimpase
Copy link
Member

dimpase commented Jun 15, 2020

@dimpase
Copy link
Member

dimpase commented Jun 15, 2020

Changed commit from 72346ef to 7a6cb81

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

comment:11

... but why?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

Changed commit from 7a6cb81 to 72346ef

@vbraun
Copy link
Member

vbraun commented Jun 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants