-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script packages should cd into the SPKG directory #29793
Comments
Commit: |
Last 10 new commits:
|
comment:3
Branch is on top of #29345. There is only 1 new commit. |
Reviewer: Michael Orlitzky |
comment:4
LGTM but is there some documentation that says what the initial working directory of spkg-install should be? It shouldn't be an implementation detail. |
comment:5
Indeed I forgot to update the documentation |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
Even better. |
comment:9
Thank you! |
comment:10
rebased over rebased #29345 Last 10 new commits:
|
comment:11
... but why? |
Changed branch from u/mkoeppe/script_packages_should_cd_into_the_spkg_directory to |
This simplifies several
spkg-install
scripts and make script packages a bit more similar to normal packages.This is a step towards #29386 (Install script packages via
sage-spkg
).Depends on #29345
CC: @jhpalmieri @embray @orlitzky @dimpase
Component: build
Author: Matthias Koeppe
Branch/Commit:
72346ef
Reviewer: Michael Orlitzky
Issue created by migration from https://trac.sagemath.org/ticket/29793
The text was updated successfully, but these errors were encountered: