Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyhedronFace: Add method to compute affine tangent cones #29811

Closed
mkoeppe opened this issue Jun 6, 2020 · 11 comments
Closed

PolyhedronFace: Add method to compute affine tangent cones #29811

mkoeppe opened this issue Jun 6, 2020 · 11 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.4

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 6, 2020

In analogy to the existing method normal_cone.

For #29806 (Gram-Brianchon formula) I only need the (affine) tangent cones of a face, tcone(P, F). See for example https://epubs.siam.org/doi/pdf/10.1137/1.9781611972443.ch6 Def 6.2.2

CC: @jplab @kliem @orlitzky @yuan-zhou @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: 5965400

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29811
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 6, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 13, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 13, 2021

comment:3

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title PolyhedronFace: Add methods to compute cones of feasible directions and affine tangent cones PolyhedronFace: Add method to compute affine tangent cones Jun 12, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Branch: u/mkoeppe/polyhedronface__add_method_to_compute_affine_tangent_cones

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

New commits:

5965400PolyhedronFace.affine_tangent_cone: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Commit: 5965400

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 17, 2021

comment:8

Patchbot is green modulo the unrelated misc/package failure

@kliem
Copy link
Contributor

kliem commented Jul 6, 2021

comment:10

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 6, 2021

Reviewer: Jonathan Kliem

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 6, 2021

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 9, 2021

Changed branch from u/mkoeppe/polyhedronface__add_method_to_compute_affine_tangent_cones to 5965400

@vbraun vbraun closed this as completed in 04c939d Jul 9, 2021
This was referenced Jan 7, 2023
Open
Open
Closed
@louisng114 louisng114 mannequin mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem