-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated alias Polyhedron_base.affine_hull by a new method #31963
Milestone
Comments
Commit: |
Last 10 new commits:
|
Author: Matthias Koeppe |
comment:4
You should add the method to the polyhedron quickref in docs. Otherwise it's good to go. Had a green bot weeks ago and everything still works. |
Reviewer: Jonathan Kliem |
comment:7
Thanks! |
Changed branch from u/mkoeppe/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#29326, renaming
affine_hull
toaffine_hull_projection
, was merged in 9.1 (released May 21, 2020).We replace this alias by a new method
affine_hull
that ... computes the affine hull as a polyhedron defined by just the equations. This will conform to the ABC for convex sets (#31919)As a courtesy, if unknown keyword arguments are passed, we point users to the renamed method.
Depends on #29811
CC: @kliem @jplab @tscrim
Component: geometry
Author: Matthias Koeppe
Branch/Commit:
dfbd801
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/31963
The text was updated successfully, but these errors were encountered: