Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated alias Polyhedron_base.affine_hull by a new method #31963

Closed
mkoeppe opened this issue Jun 12, 2021 · 12 comments
Closed

Replace deprecated alias Polyhedron_base.affine_hull by a new method #31963

mkoeppe opened this issue Jun 12, 2021 · 12 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 12, 2021

#29326, renaming affine_hull to affine_hull_projection, was merged in 9.1 (released May 21, 2020).

We replace this alias by a new method affine_hull that ... computes the affine hull as a polyhedron defined by just the equations. This will conform to the ABC for convex sets (#31919)

As a courtesy, if unknown keyword arguments are passed, we point users to the renamed method.

Depends on #29811

CC: @kliem @jplab @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: dfbd801

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31963

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 12, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 12, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 12, 2021

Changed dependencies from #31919 to #31919, #29811

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 12, 2021

Commit: d37c710

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 12, 2021

Last 10 new commits:

9a7ce3asrc/sage/geometry/convex_set.py: More examples and tests
e2b0ef7ConvexSet_base._test_convex_set: Fix doctest output
45c840aConvexSet_base.codim, codimension: New
17467c4ConvexSet_base: Make dimension, ambient_dimension aliases for dim, ambient_dim
fa5dc6eConvexSet_base.cartesian_product: New
f4bdffdConvexSet_base.contains, intersection: New
465b0cbMerge #31919
5965400PolyhedronFace.affine_tangent_cone: New
3f13401Merge #29811
d37c710Polyhedron_base.affine_hull: New, replace deprecated alias for affine_hull_projection

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 12, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 6, 2021

Changed dependencies from #31919, #29811 to #29811

@kliem
Copy link
Contributor

kliem commented Jul 6, 2021

comment:4

You should add the method to the polyhedron quickref in docs.

Otherwise it's good to go. Had a green bot weeks ago and everything still works.

@kliem
Copy link
Contributor

kliem commented Jul 6, 2021

Reviewer: Jonathan Kliem

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Changed commit from d37c710 to dfbd801

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

314e46aMerge tag '9.4.beta4' into t/31963/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method
dfbd801src/doc/en/thematic_tutorials/geometry/polyhedra_quickref.rst: Add affine_hull

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 7, 2021

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 18, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants