Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken double description of hypercube #29904

Closed
kliem opened this issue Jun 19, 2020 · 10 comments
Closed

Broken double description of hypercube #29904

kliem opened this issue Jun 19, 2020 · 10 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 19, 2020

Turns out the double description of the hypercube after #28866 is not set up incorrectly.

This wasn't detected due to a meaningless doctest.

sage: intervals = [[-2,2]]
sage: polytopes.hypercube(1, intervals)
A 0-dimensional polyhedron in ZZ^1 defined as the convex hull of 1 vertex

Component: geometry

Author: Jonathan Kliem

Branch/Commit: e1bf211

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29904

@kliem kliem added this to the sage-9.2 milestone Jun 19, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 19, 2020

New commits:

5c7e562fix double description of hypercube

@kliem
Copy link
Contributor Author

kliem commented Jun 19, 2020

Branch: public/29904

@kliem
Copy link
Contributor Author

kliem commented Jun 19, 2020

Commit: 5c7e562

@mkoeppe
Copy link
Member

mkoeppe commented Jun 20, 2020

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

comment:3

Thank you.

@orlitzky
Copy link
Contributor

comment:4

We really need to turn off the fake randomness by default in doctests. I've missed so many bugs in exactly the same way.

@kliem
Copy link
Contributor Author

kliem commented Jun 22, 2020

comment:5

I agree. I just posted about this on sage-devel.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

e1bf211remove set_random_seed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Changed commit from 5c7e562 to e1bf211

@vbraun
Copy link
Member

vbraun commented Jun 24, 2020

Changed branch from public/29904 to e1bf211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants