Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geometry doctests ready for random seeds #29963

Closed
kliem opened this issue Jun 24, 2020 · 20 comments
Closed

Make geometry doctests ready for random seeds #29963

kliem opened this issue Jun 24, 2020 · 20 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/geometry/

pass for different values n than just 0 except for
src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py, which will be taken care of by #29936.

Depends on #29962
Depends on #29904

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: f7dc36b

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/29963

@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Last 10 new commits:

998b1b9default random seed 0 for now
23ed583fix doctest in hyperbolic_space/hyperbolic_point
5283dc4use abs tol flag
7b244c0modify doctests to the extend that they hold with fuzz
228f379Merge branch 'public/29936' of git://trac.sagemath.org/sage into public/29962
5c7e562fix double description of hypercube
e1bf211remove set_random_seed
0e7a998Merge branch 'public/29904' of git://trac.sagemath.org/sage into public/29962
b6a5dc7fix random test in geometry/linear_expression
00c7575dash instead of underscore for command line options

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Branch: public/29963

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Commit: 00c7575

@kliem
Copy link
Contributor Author

kliem commented Jul 9, 2020

Changed commit from 00c7575 to d67da8b

@kliem
Copy link
Contributor Author

kliem commented Jul 9, 2020

New commits:

6e57f0cMerge branch 'public/29963' of git://trac.sagemath.org/sage into public/29963-reb
d67da8btest whether a random element has the correct parent

@kliem
Copy link
Contributor Author

kliem commented Jul 9, 2020

Changed branch from public/29963 to public/29963-reb

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

Changed branch from public/29963-reb to public/29963-reb2

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

Changed commit from d67da8b to 0f59b95

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

New commits:

1d7b00edash instead of underscore for command line options
b31e2d5Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb
2f30dd9small fixes
b62f781doctests do not start from a random seed by default yet
1d99129fix merge conflict
0f59b95fixed merge conflict

@kliem
Copy link
Contributor Author

kliem commented Jul 13, 2020

Changed commit from 0f59b95 to f7dc36b

@kliem
Copy link
Contributor Author

kliem commented Jul 13, 2020

Changed branch from public/29963-reb2 to public/29963-reb3

@kliem
Copy link
Contributor Author

kliem commented Jul 13, 2020

comment:4

This is not based on #29936 anymore.

Note that #29936 fixes a sign error in geometry/hyperbolic_space/hyperbolic_geodesic.py.


New commits:

7e4c90bfix doctest in hyperbolic_space/hyperbolic_point
f7dc36bmake random doctest fuzz ready

@seblabbe
Copy link
Contributor

Changed dependencies from #29962, #29904, #29936 to #29962, #29904

@kliem
Copy link
Contributor Author

kliem commented Aug 14, 2020

comment:6

If we want to make this independent of #29936, we need to change the objective.

It is just not based on #29936 to avoid constant merge conflicts. However, #29936 needs to be taken care of or we need to mark those things as known bugs.

@seblabbe
Copy link
Contributor

comment:7

If the issue with src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py is taken care of in another ticket, then the branch on this ticket can go in. It does not have to wait. I would suggest to downgrade the goal of this ticket to what the branch does.

@kliem

This comment has been minimized.

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@seblabbe
Copy link
Contributor

comment:9

works for me

@kliem
Copy link
Contributor Author

kliem commented Aug 14, 2020

comment:10

Thank you.

@vbraun
Copy link
Member

vbraun commented Aug 16, 2020

Changed branch from public/29963-reb3 to f7dc36b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants