-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-enter doesn't work in the notebook in firefox on the mac #3
Comments
comment:1
let's see if this "reassign" functionality works.... (i.e. does it fix the bug? :-)) |
comment:2
For the record it does work with Safari... |
This bug is in firefox, not SAGE. https://bugzilla.mozilla.org/show_bug.cgi?id=106048 Any reasonable workaround in my code would break future versions. It would also require a rather massive rewrite of otherwise good (IMO) code. In the meantime, mac users can pull the patch at my darcs repository entitled "firefox mac workaround: ctrl+enter -> alt+enter". My repository is located at: |
### 📚 Description Trac branch `u/gh-collares/gap-gc` from #34701, now migrated to GitHub. Currently based atop #35093; will rebase once that is merged. The rest of the description below is copied from #34701: A refactor in #27946 introduced "unprotected" (not surrounded by `GAP_Enter`/`GAP_Leave`) `GAP_ValueGlobalVariable` calls. I believe this might be a GC hazard, because after updating to GAP 4.12.1 I started seeing aarch64 crashes on NixOS infrastructure such as: ``` #0 0x0000fffff79740e8 in wait4 () #1 0x0000fffff5dc6b78 in print_enhanced_backtrace () #2 0x0000fffff5dc8190 in sigdie () #3 0x0000fffff5dcb1c0 in cysigs_signal_handler () #4 0x0000fffff7ffb7cc in __kernel_rt_sigreturn () #5 0x0000ffff99a0bf28 in ConvString () #6 0x0000000000000000 in ?? () #7 0x0000000000000000 in ?? () #8 0x0000000000000000 in ?? () #9 0x0000ffff99989930 in Pr () #10 0x0000ffff9998aa18 in CloseOutput () #11 0x0000ffff99884828 in capture_stdout () at /build/sage- src-9.7/pkgs/sagemath-standard/sage/libs/gap/element.pyx:154 ... ``` I also see cases where `capture_stdout` throws errors such as `sage.libs.gap.util.GAPError: Error, Length: <list> must be a list (not the integer 255)` and then crashes. Both types of errors are fixed by this ticket. Note that I am nesting `GAP_Enter`/`GAP_Leave` calls because I didn't remove the preexisting calls inside `capture_stdout`. That's because I feared removing the innermost calls might create a new footgun (and I believe nested `GAP_Enter`/`GAP_Leave` calls are explicitly supported), but removing them should cause no problem. Removing them might even be preferable for performance reasons, I don't know. Fixes #34701 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> - #35093: GAP 4.12.2 upgrade, which touches the same function and should land first. URL: #35114 Reported by: Mauricio Collares Reviewer(s): Dima Pasechnik
Adding implementation keyword to rings/morphisms
Added the covering array file to documentation, fixed a couple format…
….0 to 0.2.0 Bumps [dev-hanz-ops/install-gh-cli-action](https://github.com/dev-hanz- ops/install-gh-cli-action) from 0.1.0 to 0.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dev-hanz-ops/install-gh- cli-action/releases">dev-hanz-ops/install-gh-cli-action's releases</a>.</em></p> <blockquote> <h2>v0.2.0 - update to node20</h2> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410">https://github.com/dev-hanz- ops/install-gh-cli- action/commit/8fff9050dae2d81b38f94500d8b74ad1d1d47410</a> (update to node20)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410"><code>8fff905</code></a> update to node 20</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/67bfd0539397d168c77ba70eac2647fef7f1f020"><code>67bfd05</code></a> README: only linux amd64</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/44745680363a7ba976f907c6d1b697a9fc311cf7"><code>4474568</code></a> Update readme with working example (<a href="https://redirect.github.com/dev-hanz-ops/install-gh-cli- action/issues/3">sagemath#3</a>)</li> <li>See full diff in <a href="https://github.com/dev-hanz-ops/install- gh-cli-action/compare/v0.1.0...v0.2.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency-name=dev- hanz-ops/install-gh-cli-action&package-manager=github_actions&previous- version=0.1.0&new- version=0.2.0)](https://docs.github.com/en/github/managing-security- vulnerabilities/about-dependabot-security-updates#about-compatibility- scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> URL: sagemath#37945 Reported by: dependabot[bot] Reviewer(s):
….0 to 0.2.0 Bumps [dev-hanz-ops/install-gh-cli-action](https://github.com/dev-hanz- ops/install-gh-cli-action) from 0.1.0 to 0.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dev-hanz-ops/install-gh- cli-action/releases">dev-hanz-ops/install-gh-cli-action's releases</a>.</em></p> <blockquote> <h2>v0.2.0 - update to node20</h2> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410">https://github.com/dev-hanz- ops/install-gh-cli- action/commit/8fff9050dae2d81b38f94500d8b74ad1d1d47410</a> (update to node20)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410"><code>8fff905</code></a> update to node 20</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/67bfd0539397d168c77ba70eac2647fef7f1f020"><code>67bfd05</code></a> README: only linux amd64</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/44745680363a7ba976f907c6d1b697a9fc311cf7"><code>4474568</code></a> Update readme with working example (<a href="https://redirect.github.com/dev-hanz-ops/install-gh-cli- action/issues/3">sagemath#3</a>)</li> <li>See full diff in <a href="https://github.com/dev-hanz-ops/install- gh-cli-action/compare/v0.1.0...v0.2.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency-name=dev- hanz-ops/install-gh-cli-action&package-manager=github_actions&previous- version=0.1.0&new- version=0.2.0)](https://docs.github.com/en/github/managing-security- vulnerabilities/about-dependabot-security-updates#about-compatibility- scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> URL: sagemath#37945 Reported by: dependabot[bot] Reviewer(s):
….0 to 0.2.0 Bumps [dev-hanz-ops/install-gh-cli-action](https://github.com/dev-hanz- ops/install-gh-cli-action) from 0.1.0 to 0.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dev-hanz-ops/install-gh- cli-action/releases">dev-hanz-ops/install-gh-cli-action's releases</a>.</em></p> <blockquote> <h2>v0.2.0 - update to node20</h2> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410">https://github.com/dev-hanz- ops/install-gh-cli- action/commit/8fff9050dae2d81b38f94500d8b74ad1d1d47410</a> (update to node20)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410"><code>8fff905</code></a> update to node 20</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/67bfd0539397d168c77ba70eac2647fef7f1f020"><code>67bfd05</code></a> README: only linux amd64</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/44745680363a7ba976f907c6d1b697a9fc311cf7"><code>4474568</code></a> Update readme with working example (<a href="https://redirect.github.com/dev-hanz-ops/install-gh-cli- action/issues/3">sagemath#3</a>)</li> <li>See full diff in <a href="https://github.com/dev-hanz-ops/install- gh-cli-action/compare/v0.1.0...v0.2.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency-name=dev- hanz-ops/install-gh-cli-action&package-manager=github_actions&previous- version=0.1.0&new- version=0.2.0)](https://docs.github.com/en/github/managing-security- vulnerabilities/about-dependabot-security-updates#about-compatibility- scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> URL: sagemath#37945 Reported by: dependabot[bot] Reviewer(s):
….0 to 0.2.0 Bumps [dev-hanz-ops/install-gh-cli-action](https://github.com/dev-hanz- ops/install-gh-cli-action) from 0.1.0 to 0.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dev-hanz-ops/install-gh- cli-action/releases">dev-hanz-ops/install-gh-cli-action's releases</a>.</em></p> <blockquote> <h2>v0.2.0 - update to node20</h2> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410">https://github.com/dev-hanz- ops/install-gh-cli- action/commit/8fff9050dae2d81b38f94500d8b74ad1d1d47410</a> (update to node20)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/8fff9050dae2d81b38f94500d8b74ad1d1d47410"><code>8fff905</code></a> update to node 20</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/67bfd0539397d168c77ba70eac2647fef7f1f020"><code>67bfd05</code></a> README: only linux amd64</li> <li><a href="https://github.com/dev-hanz-ops/install-gh-cli-action/commi t/44745680363a7ba976f907c6d1b697a9fc311cf7"><code>4474568</code></a> Update readme with working example (<a href="https://redirect.github.com/dev-hanz-ops/install-gh-cli- action/issues/3">sagemath#3</a>)</li> <li>See full diff in <a href="https://github.com/dev-hanz-ops/install- gh-cli-action/compare/v0.1.0...v0.2.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency-name=dev- hanz-ops/install-gh-cli-action&package-manager=github_actions&previous- version=0.1.0&new- version=0.2.0)](https://docs.github.com/en/github/managing-security- vulnerabilities/about-dependabot-security-updates#about-compatibility- scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> URL: sagemath#37945 Reported by: dependabot[bot] Reviewer(s):
Remove excessive blank lines around INPUT, OUTPUT, EXAMPLES, and before docstring ending """. (sagemath#3)
Fix doctests for pari 2.17 on 32-bit
Summary says it all.....
Firefox version string:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Component: basic arithmetic
Issue created by migration from https://trac.sagemath.org/ticket/3
The text was updated successfully, but these errors were encountered: