ECL 20.4.24: More trouble with makeinfo

[mkoeppe]

https://groups.google.com/d/msg/sage-devel/2zjlIEsKETU/PkM3_eh1CAAJ

Upstream: Completely fixed; Fix reported upstream

CC: @dimpase @spaghettisalat @mwageringel

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 42e6c43

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30173

[dimpase]

comment:1

this looks like a locale issue - makeinfo is found, but

perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LC_ALL = "C.UTF-8",
	LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
user-guide/embedding.txi:14: warning: unreferenced node `Starting and Stopping'
user-guide/embedding.txi:14: warning: node `Catching Errors and Managing Interrupts' is next for `Starting and Stopping' in sectioning but not in menu
user-guide/embedding.txi:14: warning: node `Embedding ECL - Embedding Reference' is up for `Starting and Stopping' in sectioning but not in menu
user-guide/embedding.txi:11: node `Embedding ECL - Embedding Reference' lacks menu item for `Starting and Stopping' despite being its Up target
user-guide/embedding.txi:127: warning: unreferenced node `Catching Errors and Managing Interrupts'
user-guide/embedding.txi:127: warning: node `Starting and Stopping' is prev for `Catching Errors and Managing Interrupts' in sectioning but not in menu
user-guide/embedding.txi:127: warning: node `Embedding ECL - Embedding Reference' is up for `Catching Errors and Managing Interrupts' in sectioning but not in menu
user-guide/embedding.txi:11: node `Embedding ECL - Embedding Reference' lacks menu item for `Catching Errors and Managing Interrupts' despite being its Up target
make[7]: *** [ecl.info.gz] Error 1
make[6]: *** [info] Error 2
make[5]: *** [doc] Error 2
make[4]: *** [all] Error 2

[dimpase]

comment:2

or, perhaps, a very old version of makeinfo (however, it's in /usr/local/bin on a Mac,
so a special effort was needed to get an old one...)

[spaghettisalat]

comment:3

How about just not building the manual at all by passing --disable-manual to the configure script? Running sagemath doesn't require the manual to be there anyway.

[mkoeppe]

comment:4

Replying to @spaghettisalat:

How about just not building the manual at all by passing --disable-manual to the configure script? Running sagemath doesn't require the manual to be there anyway.

Yes, that's what we should do on this ticket

[mkoeppe]

Branch: u/mkoeppe/ecl_20_4_24__more_trouble_with_makeinfo

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

c235031

build/pkgs/ecl/spkg-install.in: Do not build the manual

[mkoeppe]

Commit: c235031

[dimpase]

comment:7

disabling this due to a possibly broken tool is a bit lame. Tools are meant to be either working or not installed.

[dimpase]

comment:8

a correct way would be to test makeinfo version in ECL itself.

Anyhow, the old makeinfo on macOS which creates problems can be tested for by

makeinfo -c foo 2>&1 | grep invalid

this returns something nonempty on makeinfo 4.8, and will be empty on a modern makeinfo - or when there is no makeinfo available.

I suggest that this test is used in spkg-install to test whether the flag --disable-manual should be used, or not.

[dimpase]

comment:9

I've submitted https://gitlab.com/embeddable-common-lisp/ecl/-/merge_requests/221 upstream, to fix this properly.

[dimpase]

Upstream: Completely fixed; Fix reported upstream

[mkoeppe]

comment:10

Great. We could still suppress building the manual if "$SAGE_SPKG_INSTALL_DOCS" != yes like on the maxima upgrade ticket (#30063).

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5e8765e

build/pkgs/ecl/spkg-install.in: Disable building the manual if SAGE_SPKG_INSTALL_DOCS != yes

[sagetrac-git]

Changed commit from c235031 to 5e8765e

[sagetrac-git]

Changed commit from 5e8765e to 42e6c43

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

42e6c43

build/pkgs/ecl/spkg-install.in: Add test for makeinfo -c

[dimpase]

Reviewer: Dima Pasechnik

[dimpase]

comment:13

lgtm

[vbraun]

Changed branch from u/mkoeppe/ecl_20_4_24__more_trouble_with_makeinfo to 42e6c43