improve cone containment tests

[orlitzky]

If K is a polyhedral cone, the test x in K only supports x with rational coordinates. It is desirable in many cases to perform the same test with irrational numbers as well.

This will simplify the implementation in ticket #29169.

CC: @kliem @jplab @novoselt

Component: geometry

Author: Michael Orlitzky

Branch/Commit: 7ea2dd8

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/30605

[novoselt]

comment:1

I was thinking what should be done with reals and other non-exact things, but I think it does not matter - as long as exact ones are handled correctly, it is user's responsibility to be aware that non-exact things may give wrong results without extra care.

[orlitzky]

comment:2

The difficulty is never where you think it will be...

sage: bool(I >= 0)                                                              
True

[orlitzky]

comment:3

Maybe this suffices?

---

New commits:

cf36516	Trac #30605: try AA before RR in cone._ambient_space_point().
276db84	Trac #30605: catch more coercion failures in cone._ambient_space_point().
507affb	Trac #30605: factor out repetition in cone._ambient_space_point().

[orlitzky]

Branch: u/mjo/ticket/30605

[orlitzky]

Commit: 507affb

[orlitzky]

Author: Michael Orlitzky

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

09c2fa3

Trac #30605: update polyhedral cone containment documentation.

[sagetrac-git]

Changed commit from 507affb to 09c2fa3

[kliem]

Reviewer: Jonathan Kliem

[kliem]

comment:6

Could you follow the recommendation of pycodestyle and do one command per line, e.g.

-        if p is not None: return p
+        if p is not None:
+            return p

or

-        try: return L.base_extend(ring)(data)
-        except TypeError: pass
-        except ValueError as ex:
-            if str(ex).startswith("Cannot coerce"): pass
+        try:
+            return L.base_extend(ring)(data)
+        except TypeError:
+            pass
+        except ValueError as ex:
+            if str(ex).startswith("Cannot coerce"):
+                pass

I think this make it easier to read.

Once done, you can set in on positive review on my behalf.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7ea2dd8

Trac #30605: reformat according to pycodestyle.

[sagetrac-git]

Changed commit from 09c2fa3 to 7ea2dd8

[orlitzky]

comment:8

Thanks! I fixed the indentation in one final (separate) commit if you want to take a look. But pycodestyle is happy now.

[vbraun]

Changed branch from u/mjo/ticket/30605 to 7ea2dd8