Experimental support for Python 3.10 in Sage 9.5 #30766

slel · 2020-10-13T21:33:40Z

This is to support Python 3.10, which was released on 2021-10-04.
https://docs.python.org/3.10/whatsnew/changelog.html#changelog

Thanks to the following tickets, Sage is mostly ready for
Python 3.10 in addition to 3.9, 3.8, 3.7.

needs Cython 0.29.23 (cython: Upgrade to 0.29.24, fix Cython 3.0 future-warnings #31445)
Upgrade gmpy2 to add python 3.10 support #31855 Patch/upgrade gmpy2 to add python 3.10 support
pyzmq: Update to 22.0.3; babel: Update to 2.9.1 #31856 Upgrade pyzmq, babel - to fix error: implicit declaration of function 'PyObject_AsWriteBuffer' is invalid in C99 with pyzmq-19.0.2
Update numpy to 1.21.4, networkx to 2.6.3 #32815 numpy
cffi: Update to 1.15.0 #32837 cffi: Update to 1.15.0
Update traitlets to 5.1.1 (for python 3.9.8, 3.10) #32852 Update traitlets to 5.1.1 (for python 3.9.8, 3.10)
Update pip to 21.3.1, distlib to 0.3.3 #32671 Update pip to 21.3.1, distlib to 0.3.3
Meta-ticket: Replace imports from deprecated distutils #31295 Meta-ticket: Replace imports from deprecated distutils
IPython/Jupyter upgrade for python 3.10 support #32930 IPython/Jupyter upgrade for python 3.10 support
Fix tests with Python 3.10 #33013 Fix tests with Python 3.10

In this ticket, we enable use of system Python 3.10 but issue a warning regarding its experimental status for Sage.

The ticket does not include the upgrade of the python3 SPKG to Python 3.10. Many systems already ship Python 3.10. To test, thanks to https://wiki.sagemath.org/ReleaseTours/sage-9.5#Separate_virtual_environment_for_Python_packages, a full rebuild of the Sage distribution is not necessary - only the Python packages will be built from scratch in a separate venv.

PEP 619 -- Python 3.10 Release Schedule
What's new in Python 3.10
Update Python to 3.10.x #30767: Upgrade to Python 3.10
Support Python 3.9 #30184: Support Python 3.9
Adopt the “time window-based” policy for support of Python versions from NEP 29 #30384: Adopt the “time window-based” policy for support of Python versions from NEP 29

Depends on #33013
Depends on #32930
Depends on #33040

CC: @mkoeppe @slel @kiwifb @tornaria @antonio-rojas

Component: packages: standard

Keywords: upgrade, python

Author: Matthias Koeppe, Gonzalo Tornaría

Branch: df9f1d4

Reviewer: Antonio Rojas, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30766

The text was updated successfully, but these errors were encountered:

slel · 2020-10-13T21:44:34Z

Changed keywords from none to upgrade, python

slel · 2020-10-15T11:19:31Z

Dependencies: #30768

mkoeppe · 2021-04-14T18:29:13Z

Changed dependencies from #30768 to #30768, #31445

mkoeppe · 2021-05-24T23:46:38Z

Branch: u/mkoeppe/support_python_3_10

mkoeppe · 2021-05-24T23:56:14Z

New commits:

`6ca849f`	`build/pkgs/cython: Update to 0.29.23`
`4e4fd58`	`Merge #31445`

mkoeppe · 2021-05-24T23:56:14Z

Commit: 4e4fd58

mkoeppe · 2021-05-25T00:03:08Z

Changed dependencies from #30768, #31445 to #30768, #31445, #31855

sagetrac-git · 2021-05-25T00:03:32Z

Changed commit from 4e4fd58 to 2d7d715

sagetrac-git · 2021-05-25T00:03:32Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8cd9ece`	`build/pkgs/gmpy2/patches: Add patches from Fedora @python/python3.10`
`2d7d715`	`Merge #31855`

sagetrac-git · 2021-05-25T00:06:56Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3321a59`	`build/pkgs/python3/spkg-configure.m4: Accept system python 3.10.x`

sagetrac-git · 2021-05-25T00:06:56Z

Changed commit from 2d7d715 to 3321a59

mkoeppe · 2021-05-25T00:19:21Z

Changed dependencies from #30768, #31445, #31855 to #30768, #31445, #31855, #31856

sagetrac-git · 2021-05-25T00:20:33Z

Changed commit from 3321a59 to 65355f9

sagetrac-git · 2021-05-25T00:20:33Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2a7d940`	`build/pkgs/pyzmq: Update to 22.0.3`
`65355f9`	`Merge #31856`

mkoeppe · 2021-05-25T00:27:29Z

Changed dependencies from #30768, #31445, #31855, #31856 to #30768, #31445, #31855, #31856, #31008

sagetrac-git · 2021-05-25T00:29:29Z

Changed commit from 65355f9 to a661b6a

tornaria · 2021-12-19T22:10:27Z

comment:95

I change the workarounds by an attempt at a "proper" fix.

With this all the doctests in src/sage/cpython/atexit.pyx pass, both with bundled python 3.9.7 and with my system python 3.10.

I'm still to run the whole testsuite; I am still getting failures in src/sage_docbuild/utils.py but I think they are due to the deprecation warnings caused by matplotlib and should go away when I apply #33040 which I forgot to do.

Should #33040 be merged into this ticket as a dependency? Am I the only one having problems caused by old matplotlib?

New commits:

`249357d`	`sage.cpython.atexit: fix for python 3.10 (#30766)`

tornaria · 2021-12-19T22:22:23Z

comment:96

Notes on the implementation:

Everything is in the cdef extern from * block where I moved the definition of struct atexit_callback and a new function _atexit_callbacks().

The C implementation for python 3.9 is short and should be equivalent to what was before. The implementation for 3.10 is even shorter since structs are now defined in (internal) python headers.

The argument to _atexit_callbacks() should be the atexit module as in the body of _get_exithandlers(). This is not necessary for python 3.10 but it seemed simpler to have the same declaration for both cases so there are no conditionals outside the cdef extern from * block.

mkoeppe · 2021-12-19T22:25:06Z

Changed dependencies from #33013, #32930 to #33013, #32930, #33040

mkoeppe · 2021-12-19T22:26:18Z

comment:98

Looks good to me but it needs to be tested also on Python < 3.10

mkoeppe · 2021-12-19T22:27:12Z

Changed author from Matthias Koeppe to Matthias Koeppe, Gonzalo Tornaría

tornaria · 2021-12-19T23:01:47Z

comment:100

Replying to @mkoeppe:

Looks good to me but it needs to be tested also on Python < 3.10

Absolutely! I did one test by passing --without-system-python3 to configure but more testing would be desirable.

Although I think the changes should really be nil for python < 3.10; would it be useful for review if I split the patch in two parts where the first part just refactors the existing code and the second part adds the new code for python 3.10? With some luck the first part visibly does nothing, and the second part will only add code conditional to python >= 3.10.

mkoeppe · 2021-12-19T23:03:07Z

comment:101

Replying to @tornaria:

would it be useful for review if I split the patch in two parts where the first part just refactors the existing code and the second part adds the new code for python 3.10?

No, it's fine as is

tornaria · 2021-12-19T23:04:38Z

comment:102

My full clean build with python 3.10 finished with the following doctest failure:

sage -t --random-seed=262548395979960264449538514011341238171 src/sage_docbuild/utils.py
**********************************************************************
File "src/sage_docbuild/utils.py", line 91, in sage_docbuild.utils
Failed example:
    build_many(target, range(8), processes=8)
Expected:
    Traceback (most recent call last):
    ...
    ZeroDivisionError: rational division by zero
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/usr/lib/sage-9.5.beta8/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/sage/doctest/forker.py", line 694, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/sage-9.5.beta8/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/sage/doctest/forker.py", line 1088, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage_docbuild.utils[6]>", line 1, in <module>
        build_many(target, range(Integer(8)), processes=Integer(8))
      File "/usr/lib/sage-9.5.beta8/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/sage_docbuild/utils.py", line 289, in build_many
        raise worker_exc.original_exception
    TypeError: 'sage.rings.real_mpfr.RealLiteral' object cannot be interpreted as an integer
**********************************************************************
File "src/sage_docbuild/utils.py", line 110, in sage_docbuild.utils
Failed example:
    build_many(target, range(8), processes=8)
Expected:
    Traceback (most recent call last):
    ...
    WorkerDiedException: worker for 4 died with non-zero exit code -9
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/usr/lib/sage-9.5.beta8/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/sage/doctest/forker.py", line 694, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/sage-9.5.beta8/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/sage/doctest/forker.py", line 1088, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage_docbuild.utils[8]>", line 1, in <module>
        build_many(target, range(Integer(8)), processes=Integer(8))
      File "/usr/lib/sage-9.5.beta8/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/sage_docbuild/utils.py", line 289, in build_many
        raise worker_exc.original_exception
    TypeError: 'sage.rings.real_mpfr.RealLiteral' object cannot be interpreted as an integer
**********************************************************************
1 item had failures:
   2 of  10 in sage_docbuild.utils
    [9 tests, 2 failures, 1.43 s]

sagetrac-git · 2021-12-20T01:38:24Z

Branch pushed to git repo; I updated commit sha1. New commits:

`df9f1d4`	`Pass float(0.5) to time.sleep`

sagetrac-git · 2021-12-20T01:38:24Z

Changed commit from 249357d to df9f1d4

tornaria · 2021-12-20T01:38:51Z

comment:104

This seems to be the root cause:

┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 9.5.beta8, Release Date: 2021-12-12               │
│ Using Python 3.10.1. Type "help()" for help.                       │
└────────────────────────────────────────────────────────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Warning: this is a prerelease version, and it may be unstable.     ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
sage: import time
sage: time.sleep(0.5)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-2-b448069dbb3c> in <module>
----> 1 time.sleep(RealNumber('0.5'))

TypeError: 'sage.rings.real_mpfr.RealLiteral' object cannot be interpreted as an integer

Now the same thing --without-system-python:

┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 9.5.beta8, Release Date: 2021-12-12               │
│ Using Python 3.9.7. Type "help()" for help.                        │
└────────────────────────────────────────────────────────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Warning: this is a prerelease version, and it may be unstable.     ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
sage: import time
sage: time.sleep(0.5)
<ipython-input-2-b448069dbb3c>:1: DeprecationWarning: an integer is required (got type sage.rings.real_mpfr.RealLiteral).  Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python.
  time.sleep(RealNumber('0.5'))

tornaria · 2021-12-20T01:57:31Z

comment:105

Everything passes now for me using system python 3.10.1 on void linux:

$ ./sage -tp 36 --optional sage,optional,build --all
...
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 236.9 seconds
    cpu time: 7024.5 seconds
    cumulative wall time: 6565.8 seconds

mkoeppe · 2021-12-20T02:44:40Z

Reviewer: ..., Matthias Koeppe

antonio-rojas · 2021-12-20T15:41:26Z

comment:107

All tests passing here too, thanks!

antonio-rojas · 2021-12-20T15:41:26Z

Changed reviewer from ..., Matthias Koeppe to Antonio Rojas, Matthias Koeppe

mkoeppe · 2021-12-20T19:57:04Z

comment:108

Thanks!

mkoeppe · 2021-12-20T19:57:50Z

comment:109

The dependency #33040 needs review so that we can get this ticket merged.

vbraun · 2022-01-01T00:23:38Z

Changed branch from u/tornaria/support_python_3_10 to df9f1d4

antonio-rojas · 2022-01-09T13:39:15Z

Changed commit from df9f1d4 to none

antonio-rojas · 2022-01-09T13:39:15Z

comment:111

Something regressed in 9.5.rc0 which is causing distutils deprecation warnings

File "/usr/lib/python3.10/site-packages/sage/env.py", line 359, in sage.env.sage_include_directories
Failed example:
    sage.env.sage_include_directories()
Expected:
    ['.../include/python...',
    '.../python.../numpy/core/include']
Got:
    doctest:warning
      File "/usr/bin/sage-runtests", line 155, in <module>
        err = DC.run()
      File "/usr/lib/python3.10/site-packages/sage/doctest/control.py", line 1256, in run
        self.run_doctests()
      File "/usr/lib/python3.10/site-packages/sage/doctest/control.py", line 957, in run_doctests
        self.dispatcher.dispatch()
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2004, in dispatch
        self.parallel_dispatch()
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 1899, in parallel_dispatch
        w.start()  # This might take some time
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2173, in start
        super(DocTestWorker, self).start()
      File "/usr/lib/python3.10/multiprocessing/process.py", line 121, in start
        self._popen = self._Popen(self)
      File "/usr/lib/python3.10/multiprocessing/context.py", line 224, in _Popen
        return _default_context.get_context().Process._Popen(process_obj)
      File "/usr/lib/python3.10/multiprocessing/context.py", line 277, in _Popen
        return Popen(process_obj)
      File "/usr/lib/python3.10/multiprocessing/popen_fork.py", line 19, in __init__
        self._launch(process_obj)
      File "/usr/lib/python3.10/multiprocessing/popen_fork.py", line 71, in _launch
        code = process_obj._bootstrap(parent_sentinel=child_r)
      File "/usr/lib/python3.10/multiprocessing/process.py", line 315, in _bootstrap
        self.run()
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2145, in run
        task(self.options, self.outtmpfile, msgpipe, self.result_queue)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2475, in __call__
        doctests, extras = self._run(runner, options, results)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2527, in _run
        result = runner.run(test)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 861, in run
        return self._run(test, compileflags, out)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 694, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 1088, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.env.sage_include_directories[1]>", line 1, in <module>
        sage.env.sage_include_directories()
      File "/usr/lib/python3.10/site-packages/sage/env.py", line 375, in sage_include_directories
        import distutils.sysconfig
      File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
      File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
      File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
      File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 883, in exec_module
      File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
      File "/usr/lib/python3.10/distutils/__init__.py", line 19, in <module>
        warnings.warn(_DEPRECATION_MESSAGE,
      File "/usr/lib/python3.10/warnings.py", line 109, in _showwarnmsg
        sw(msg.message, msg.category, msg.filename, msg.lineno,
    :
    DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
    doctest:warning
      File "/usr/bin/sage-runtests", line 155, in <module>
        err = DC.run()
      File "/usr/lib/python3.10/site-packages/sage/doctest/control.py", line 1256, in run
        self.run_doctests()
      File "/usr/lib/python3.10/site-packages/sage/doctest/control.py", line 957, in run_doctests
        self.dispatcher.dispatch()
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2004, in dispatch
        self.parallel_dispatch()
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 1899, in parallel_dispatch
        w.start()  # This might take some time
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2173, in start
        super(DocTestWorker, self).start()
      File "/usr/lib/python3.10/multiprocessing/process.py", line 121, in start
        self._popen = self._Popen(self)
      File "/usr/lib/python3.10/multiprocessing/context.py", line 224, in _Popen
        return _default_context.get_context().Process._Popen(process_obj)
      File "/usr/lib/python3.10/multiprocessing/context.py", line 277, in _Popen
        return Popen(process_obj)
      File "/usr/lib/python3.10/multiprocessing/popen_fork.py", line 19, in __init__
        self._launch(process_obj)
      File "/usr/lib/python3.10/multiprocessing/popen_fork.py", line 71, in _launch
        code = process_obj._bootstrap(parent_sentinel=child_r)
      File "/usr/lib/python3.10/multiprocessing/process.py", line 315, in _bootstrap
        self.run()
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2145, in run
        task(self.options, self.outtmpfile, msgpipe, self.result_queue)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2475, in __call__
        doctests, extras = self._run(runner, options, results)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 2527, in _run
        result = runner.run(test)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 861, in run
        return self._run(test, compileflags, out)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 694, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 1088, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.env.sage_include_directories[1]>", line 1, in <module>
        sage.env.sage_include_directories()
      File "/usr/lib/python3.10/site-packages/sage/env.py", line 375, in sage_include_directories
        import distutils.sysconfig
      File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
      File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 883, in exec_module
      File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
      File "/usr/lib/python3.10/distutils/sysconfig.py", line 58, in <module>
        warnings.warn(
      File "/usr/lib/python3.10/warnings.py", line 109, in _showwarnmsg
        sw(msg.message, msg.category, msg.filename, msg.lineno,
    :
    DeprecationWarning: The distutils.sysconfig module is deprecated, use sysconfig instead
    ['/usr/lib/python3.10/site-packages',
     '/usr/include/python3.10',
     '/usr/lib/python3.10/site-packages/numpy/core/include']
**********************************************************************

These didn't happen with 9.5.beta9 + this branch.

antonio-rojas · 2022-01-09T15:25:22Z

comment:112

Replying to @antonio-rojas:

Something regressed in 9.5.rc0 which is causing distutils deprecation warnings

This comes from #32938, in particular form the removal of

from Cython.Build.Dependencies import strip_string_literals as cython_strip_string_literals

from sage.doctest.parsing. That import used to throw a distutils deprecation warning that for some reason was ignored during doctesting, and now that it's gone the warning is printed when doctesting any module that calls distutils.sysconfig.

sheerluck · 2022-01-09T16:05:03Z

comment:113

adding internet to --optional= shows that all context=SSLContext() should be replaced with context=ssl.create_default_context()

tornaria · 2022-01-09T18:46:50Z

comment:114

These three seem to fix all the warnings for me (numpy 1.22 from system via #29665)

--- a/src/sage/all.py	2022-01-09 15:34:29.833828362 -0300
+++ b/src/sage/all.py	2022-01-09 15:39:40.150091390 -0300
@@ -96,6 +96,15 @@
 warnings.filterwarnings('ignore', category=DeprecationWarning,
                         module='pythran')
 
+warnings.filterwarnings('ignore', category=DeprecationWarning,
+			module='numpy', message='.*distutils.*')
+
+warnings.filterwarnings('ignore', category=DeprecationWarning,
+			module='sage.env', message='.*distutils.*')
+
+warnings.filterwarnings('ignore', category=DeprecationWarning,
+			module='sage.features', message='.*distutils.*')
+
 ################ end setup warnings ###############################

Edit: fixed paths in the patch.

tornaria · 2022-01-09T19:54:18Z

comment:115

Please see and review #33135.

slel added p: major / 3 labels Oct 13, 2020

This comment has been minimized.

Sign in to view

slel added the c: packages: standard label Oct 13, 2020

This comment has been minimized.

Sign in to view

mkoeppe added this to the sage-9.4 milestone Apr 14, 2021

mkoeppe removed the wishlist item label Apr 14, 2021

This comment has been minimized.

Sign in to view

antonio-rojas added s: positive review and removed s: needs review labels Dec 20, 2021

vbraun removed the s: positive review label Jan 1, 2022

vbraun closed this as completed in 935315f Jan 1, 2022

slel mentioned this issue Mar 9, 2022

Update Python to 3.10.x #30767

Closed

enriqueartal mentioned this issue Nov 6, 2021

pyzmq: Fix build errors; zeromq, pyzmq: Update; setuptools: upgrade to 59.2.0 #32828

Closed

Experimental support for Python 3.10 in Sage 9.5 #30766

Experimental support for Python 3.10 in Sage 9.5 #30766

Comments

slel commented Oct 13, 2020

slel commented Oct 13, 2020

This comment has been minimized.

slel commented Oct 15, 2020

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Apr 14, 2021

This comment has been minimized.

mkoeppe commented May 24, 2021

This comment has been minimized.

mkoeppe commented May 24, 2021

mkoeppe commented May 24, 2021

This comment has been minimized.

mkoeppe commented May 25, 2021

sagetrac-git mannequin commented May 25, 2021

sagetrac-git mannequin commented May 25, 2021

sagetrac-git mannequin commented May 25, 2021

sagetrac-git mannequin commented May 25, 2021

This comment has been minimized.

This comment has been minimized.

mkoeppe commented May 25, 2021

sagetrac-git mannequin commented May 25, 2021

sagetrac-git mannequin commented May 25, 2021

mkoeppe commented May 25, 2021

This comment has been minimized.

sagetrac-git mannequin commented May 25, 2021

tornaria commented Dec 19, 2021

tornaria commented Dec 19, 2021

mkoeppe commented Dec 19, 2021

mkoeppe commented Dec 19, 2021

mkoeppe commented Dec 19, 2021

tornaria commented Dec 19, 2021

mkoeppe commented Dec 19, 2021

tornaria commented Dec 19, 2021

sagetrac-git mannequin commented Dec 20, 2021

sagetrac-git mannequin commented Dec 20, 2021

tornaria commented Dec 20, 2021

tornaria commented Dec 20, 2021

mkoeppe commented Dec 20, 2021

antonio-rojas commented Dec 20, 2021

antonio-rojas commented Dec 20, 2021

mkoeppe commented Dec 20, 2021

mkoeppe commented Dec 20, 2021

vbraun commented Jan 1, 2022

antonio-rojas commented Jan 9, 2022

antonio-rojas commented Jan 9, 2022

antonio-rojas commented Jan 9, 2022

sheerluck commented Jan 9, 2022

tornaria commented Jan 9, 2022

tornaria commented Jan 9, 2022