Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interface to plantri #31571

Closed
slel opened this issue Mar 27, 2021 · 12 comments
Closed

Improve interface to plantri #31571

slel opened this issue Mar 27, 2021 · 12 comments

Comments

@slel
Copy link
Member

slel commented Mar 27, 2021

As suggested in David Coudert's answer to

CC: @dcoudert @slel

Component: graph theory

Keywords: plantri

Author: David Coudert

Branch/Commit: ad07e94

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31571

@slel slel added this to the sage-9.3 milestone Mar 27, 2021
@dcoudert
Copy link
Contributor

Commit: eae2799

@dcoudert
Copy link
Contributor

Branch: public/graphs/31571_planar_graphs

@dcoudert
Copy link
Contributor

comment:1

We can discuss the names of the parameters.

The method needs to be cleaned, but I let that for other tickets.


New commits:

eae2799trac #31571: more parameters for planar_graphs

@dcoudert
Copy link
Contributor

Author: David Coudert

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ad07e94trac #31571: remove useless import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2021

Changed commit from eae2799 to ad07e94

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

ok, validé

@dcoudert
Copy link
Contributor

dcoudert commented Apr 1, 2021

comment:4

In a future ticket we could allow a user to pass directly a string of commands to plantri as done in graphs.nauty_geng.

@slel
Copy link
Member Author

slel commented Apr 1, 2021

comment:5

Replying to @dcoudert:

In a future ticket we could allow a user to pass directly a string of commands to plantri as done in graphs.nauty_geng.

I opened #31590 for that.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 2, 2021

comment:6

Moving this ticket to 9.4, as it seems unlikely that it will be merged in 9.3, which is in the release candidate stage

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Apr 2, 2021
@vbraun
Copy link
Member

vbraun commented May 27, 2021

Changed branch from public/graphs/31571_planar_graphs to ad07e94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants