Initialize a Set from a ConvexSet_base instance #32013

mkoeppe · 2021-06-20T16:33:58Z

A Polyhedron is not a Parent, so Set refuses to construct the set of its elements.

We change this by creating a new abstract base class for non-necessarily-parent sets with methods union, intersection, etc.

ConvexSet_base (from #31919) and RealSet now both inherit from Set_base. To complete the implementation of the Set_base protocol, we add an implementation of RealSet.symmetric_difference.

So we can now do the following things:

sage: Set(polytopes.cube())                                                                                                                                                                          
Set of elements of A 3-dimensional polyhedron in ZZ^3 defined as the convex hull of 8 vertices
sage: polytopes.cube().union(polytopes.tetrahedron())                                                                                                                                                
Set-theoretic union of Set of elements of A 3-dimensional polyhedron in ZZ^3 defined as the convex hull of 8 vertices and Set of elements of A 3-dimensional polyhedron in ZZ^3 defined as the convex hull of 4 vertices

Depends on #30473

CC: @kliem @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: fff2a79

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32013

The text was updated successfully, but these errors were encountered:

mkoeppe · 2021-06-20T19:44:35Z

Branch: u/mkoeppe/initialize_a_set_from_a_convexset_base_instance

mkoeppe · 2021-06-20T19:50:49Z

Last 10 new commits:

`f02ca28`	`src/sage/geometry/polyhedron/face.py: Remove unused import`
`1744ffa`	`Merge #31959`
`bd8e702`	`Merge #31990`
`f351eb8`	`src/sage/sets/set.py: Split out mix-in classes Set_base, Set_boolean_operators, Set_add_sub_operators from Set_object; pycodestyle fixes`
`f1db666`	`Polyhedron_base.*contains: Return False for non-iterables - do not raise an exception`
`6237fbc`	`ConvexSet_base.is_finite, cardinality: New`
`18270ce`	`Set_object._an_element_: Handle non-iterable objects by delegating to __object.an_element`
`b8f5978`	`Set: Create a wrapper instance also for Elements that subclass Set_base`
`b67092c`	`Set_base.union, intersection, difference, symmetric_difference: Convert to Set if necessary`
`e144389`	`ConvexSet_base.intersection: Remove abstract method; now inherits Set_base.intersection`

mkoeppe · 2021-06-20T19:50:49Z

Commit: e144389

mkoeppe · 2021-06-20T19:50:49Z

Author: Matthias Koeppe

mkoeppe · 2021-06-20T19:50:49Z

Dependencies: #31990

sagetrac-git · 2021-06-21T19:08:15Z

Changed commit from e144389 to bc26d4f

sagetrac-git · 2021-06-21T19:08:15Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bc26d4f`	`{LatticePolytopeClass, ConvexRationalPolyhedralCone._some_elements_: New`

mkoeppe · 2021-06-21T19:12:21Z

Changed dependencies from #31990 to #31990, #32025

mkoeppe · 2021-06-21T20:44:30Z

Changed dependencies from #31990, #32025 to #31990, #31877, #32025

sagetrac-git · 2021-06-21T20:45:09Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`5b8ceca`	InternalRealInterval, RealSet: Add `_latex_` methods
`69ca854`	`RealSet._repr_: Use unicode cup sign instead of +`
`dbdfc06`	`InternalRealInterval, RealSet: Remove extra whitespace in latex, add documentation`
`7f56338`	`PiecewiseFunction: Adjust doctests for changed RealSet repr`
`8abdc8b`	`src/sage/functions/piecewise.py: Add coding header`
`5b0f85d`	`Merge #31880`
`e768463`	`Merge #31877`
`cb93c99`	`RealSet: Inherit from Set_base, Set_boolean_operators, Set_add_sub_operators`
`3a6f9bd`	`RealSet.symmetric_difference: New`
`afad76f`	sage.sets.set.Set_object: Add `_sympy_` methods to subclasses

sagetrac-git · 2021-06-21T20:45:09Z

Changed commit from bc26d4f to afad76f

sagetrac-git · 2021-06-21T20:53:53Z

Changed commit from afad76f to 34d920b

sagetrac-git · 2021-06-21T20:53:53Z

Branch pushed to git repo; I updated commit sha1. New commits:

`34d920b`	`Set_base._test_as_set_object: Skip _test_pickling`

mkoeppe · 2021-06-21T20:54:21Z

Changed dependencies from #31990, #31877, #32025 to #31990, #31877

sagetrac-git · 2021-06-21T20:56:53Z

Changed commit from 34d920b to 08c52c2

sagetrac-git · 2021-06-21T20:56:53Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`08c52c2`	`Set_base._test_as_set_object: Skip _test_pickling`

sagetrac-git · 2021-07-01T22:24:54Z

Branch pushed to git repo; I updated commit sha1. New commits:

`200b1ef`	`Merge tag '9.4.beta4' into t/32013/initialize_a_set_from_a_convexset_base_instance`

sagetrac-git · 2021-07-01T22:24:54Z

Changed commit from 08c52c2 to 200b1ef

tscrim · 2021-07-02T05:38:11Z

comment:12

LGTM.

tscrim · 2021-07-02T05:38:11Z

Reviewer: Travis Scrimshaw

mkoeppe · 2021-07-02T06:01:57Z

comment:13

Thanks!

mkoeppe · 2021-07-07T23:26:45Z

comment:20

Thanks!

sagetrac-git · 2021-07-07T23:45:19Z

Changed commit from 63c2cfe to 55240bb

sagetrac-git · 2021-07-07T23:45:19Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

`da8893f`	`Use sage.typeset.unicode_characters in TensorProductFunctor and SignedTensorProductFunctor`
`2a23cb5`	`Unicode symbol 2202 (partial) for the text display of coordinate frames`
`5d096f1`	`f-string for unicode_symbol in TensorProductFunctor and SignedTensorProductFunctor`
`76c2fd5`	`Use Unicode symbol for the Riemann sphere example`
`5167e6c`	`Use Unicode symbol for default text display of RealLine`
`332410b`	`Use unicode_otimes in TensorProductFunctor and SignedTensorProductFunctor`
`f5d15d2`	`Merge branch 'public/manifolds/unicode_art' of git://trac.sagemath.org/sage into Sage 9.4.beta4.`
`d87d09b`	`#30473: fix doctest error in DiffMap.pullback`
`f2ae50e`	`#30473: fix doctests outside sage/manifolds and sage/tensor/modules`
`55240bb`	`Merge #30473`

mkoeppe · 2021-07-07T23:45:50Z

Dependencies: #30473

mkoeppe · 2021-07-07T23:45:50Z

comment:22

Merged #30473 to resolve a merge conflict

vbraun · 2021-07-11T23:02:10Z

comment:23

PDF docs fail

sagetrac-git · 2021-07-11T23:26:23Z

Branch pushed to git repo; I updated commit sha1. New commits:

`fff2a79`	`src/sage/sets/set.py: Fix docstring markup`

sagetrac-git · 2021-07-11T23:26:23Z

Changed commit from 55240bb to fff2a79

mjungmath · 2021-07-13T00:41:27Z

comment:26

-        EXAMPLE::
+        EXAMPLES::

See https://wiki.sagemath.org/plugins#blocks.

tscrim · 2021-07-13T00:47:07Z

comment:27

While that is against our general practice, it is not sufficient to revert a positive review IMO. However, if Matthias wants to update it, he can go ahead and do it (and immediately reset a positive review).

mjungmath · 2021-07-13T00:47:54Z

comment:28

-        Returns the symmetric difference of ``self`` and ``X``.
+        Return the symmetric difference of ``self`` and ``X``.

etc.

See https://wiki.sagemath.org/plugins#blocks.

tscrim · 2021-07-13T00:49:09Z

comment:29

See other tickets.

mkoeppe · 2021-07-13T00:52:56Z

comment:30

Replying to @tscrim:

While that is against our general practice, it is not sufficient to revert a positive review IMO.

... in particular since this is not new code. It's not the job of a ticket to fix everything that's wrong in a given file.

mjungmath · 2021-07-13T09:23:24Z

comment:32

I have opened a ticket devoted to those deviations of convention: #32192.

vbraun · 2021-07-23T20:11:11Z

Changed branch from u/mkoeppe/initialize_a_set_from_a_convexset_base_instance to fff2a79

mkoeppe added this to the sage-9.4 milestone Jun 20, 2021

mkoeppe added c: geometry labels Jun 20, 2021

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Jun 20, 2021

This comment has been minimized.

Sign in to view

tscrim added s: positive review and removed s: needs review labels Jul 2, 2021

sagetrac-git mannequin added s: needs review and removed s: positive review labels Jul 7, 2021

mkoeppe added s: positive review and removed s: needs review labels Jul 7, 2021

vbraun added s: needs work and removed s: positive review labels Jul 11, 2021

mkoeppe added s: positive review and removed s: needs work labels Jul 11, 2021

mjungmath added s: needs work and removed s: positive review labels Jul 13, 2021

tscrim added s: positive review and removed s: needs work labels Jul 13, 2021

vbraun removed the s: positive review label Jul 23, 2021

vbraun closed this as completed in c3aaa69 Jul 23, 2021

rwst mentioned this issue May 11, 2022

ConditionSet, ImageSet: Implement formal Set comprehension #24176

Closed

Initialize a Set from a ConvexSet_base instance #32013

Initialize a Set from a ConvexSet_base instance #32013

Comments

mkoeppe commented Jun 20, 2021

mkoeppe commented Jun 20, 2021

mkoeppe commented Jun 20, 2021

mkoeppe commented Jun 20, 2021

mkoeppe commented Jun 20, 2021

mkoeppe commented Jun 20, 2021

This comment has been minimized.

sagetrac-git mannequin commented Jun 21, 2021

sagetrac-git mannequin commented Jun 21, 2021

mkoeppe commented Jun 21, 2021

mkoeppe commented Jun 21, 2021

sagetrac-git mannequin commented Jun 21, 2021

sagetrac-git mannequin commented Jun 21, 2021

sagetrac-git mannequin commented Jun 21, 2021

sagetrac-git mannequin commented Jun 21, 2021

mkoeppe commented Jun 21, 2021

sagetrac-git mannequin commented Jun 21, 2021

sagetrac-git mannequin commented Jun 21, 2021

This comment has been minimized.

sagetrac-git mannequin commented Jul 1, 2021

sagetrac-git mannequin commented Jul 1, 2021

tscrim commented Jul 2, 2021

tscrim commented Jul 2, 2021

mkoeppe commented Jul 2, 2021

mkoeppe commented Jul 7, 2021

sagetrac-git mannequin commented Jul 7, 2021

sagetrac-git mannequin commented Jul 7, 2021

mkoeppe commented Jul 7, 2021

mkoeppe commented Jul 7, 2021

vbraun commented Jul 11, 2021

sagetrac-git mannequin commented Jul 11, 2021

sagetrac-git mannequin commented Jul 11, 2021

mjungmath commented Jul 13, 2021

tscrim commented Jul 13, 2021

mjungmath commented Jul 13, 2021

tscrim commented Jul 13, 2021

mkoeppe commented Jul 13, 2021

mjungmath commented Jul 13, 2021

vbraun commented Jul 23, 2021