Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests: Upgrade to 2.26.0, add new (unvendored) deps #32372

Closed
mkoeppe opened this issue Aug 12, 2021 · 20 comments
Closed

requests: Upgrade to 2.26.0, add new (unvendored) deps #32372

mkoeppe opened this issue Aug 12, 2021 · 20 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2021

(split out from #31280)

As noted in #31280 comment:65, this helps
for #30768 and hence for Python 3.10 compatibility.

Three packages are added, each becoming
a standard spkg.

charset-normalizer

Added under the name charset_normalizer.

"Charset Detection, for Everyone"

A library that helps you read text from an unknown
charset encoding.

[...] All IANA character set names for which the
Python core library provides codecs are supported.

idna

Support for the Internationalised Domain Names
in Applications (IDNA) protocol as specified
in RFC 5891. This is the latest version of the
protocol and is sometimes referred to as “IDNA 2008”.

This library also provides support
for Unicode Technical Standard 46,
Unicode IDNA Compatibility Processing.

This acts as a suitable replacement for the
“encodings.idna” module that comes with the
Python standard library, but which only supports
the old, deprecated IDNA specification (RFC 3490).

urllib3

a powerful, user-friendly HTTP client for Python.
[...]
urllib3 brings many critical features that are
missing from the Python standard libraries:

  • Thread safety.
  • Connection pooling.
  • Client-side SSL/TLS verification.
  • File uploads with multipart encoding.
  • Helpers for retrying requests and dealing with HTTP redirects.
  • Support for gzip, deflate, and brotli encoding.
  • Proxy support for HTTP and SOCKS.
  • 100% test coverage.

CC: @fchapoton @slel @dimpase

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 8cc62de

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32372

@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 12, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2021

New commits:

764b341build/pkgs/chardet: New (unvendored from requests)
5b5e721build/pkgs/idna: New (unvendored from requests)
649f5afbuild/pkgs/urllib3: New (unvendored from requests)
b8cf517build/pkgs/requests: Update to 2.26.0
b5dc185build/pkgs/requests/dependencies: Add unvendored packages
9a05776build/pkgs/urllib3: Update to 1.26.6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2021

Commit: 9a05776

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

fbb7da9build/pkgs/idna: Update to 3.2
81af3bfbuild/pkgs/requests/checksums.ini: Add upstream_url

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2021

Changed commit from 9a05776 to 81af3bf

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 13, 2021

comment:4

requests 2.26.0 has switched from chardet to charset_normalizer
https://docs.python-requests.org/en/master/community/updates/#id1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2021

Changed commit from 81af3bf to 8cc62de

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8c8a766build/pkgs/charset_normalizer: New, use it instead of chardet as a dependency of requests
8cc62debuild/pkgs/chardet: Remove

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Aug 21, 2021

comment:7

Would a round of github-actions be a good way
to start a review of this?

@fchapoton
Copy link
Contributor

comment:8

I have launched one some hours ago. It should take 1 day or more.

https://github.com/sagemath/sagetrac-mirror/actions/runs/1153312296

@fchapoton
Copy link
Contributor

comment:9

apparently, the github CI is not able to use the "upstream_url" for "charset_normalizer"

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 21, 2021

comment:10

The download failure on ubuntu-trusty-standard https://github.com/sagemath/sagetrac-mirror/runs/3388617349?check_suite_focus=true

  [urllib3-1.26.6]   [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
  [urllib3-1.26.6]   ERROR [transfer|run:135]: [Errno 403] SNI is required: '//pypi.io/packages/source/u/urllib3/urllib3-1.26.6.tar.gz'
  [urllib3-1.26.6]   ************************************************************************
  [urllib3-1.26.6]   Traceback (most recent call last):
  [urllib3-1.26.6]     File "/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 126, in run_safe
  [urllib3-1.26.6]       run()

is new (and unrelated to #32403)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 21, 2021

comment:11

This appears to be from pypi/support#978 ("Deprecation of non-SNI compatible clients")

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 21, 2021

comment:12

I've opened #32405 for this failure; it has no technical relation to the present ticket.

@dimpase
Copy link
Member

dimpase commented Aug 30, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Aug 30, 2021

comment:14

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 30, 2021

comment:15

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants