sage.geometry.polyhedron: Mark doctests # optional - sage.combinat

[mkoeppe]

(cherry-picked from #32432)

Depends on #32614

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 3acc6a9

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32653

[mkoeppe]

Branch: u/mkoeppe/sage_geometry_polyhedron__mark_doctests___optional___sage_combinat

[sagetrac-git]

Commit: a307e92

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

1b8634d	sage.doctest.external: Add 4ti2
d9d4f99	Merge tag '9.4.beta6' into t/30887/public/30887
646e182	src/sage/features/four_ti_2.py: Move import of SAGE_ENV inside the `__init__` method, to remove confusion of sage.misc.dev_tools
180e31d	Merge #30887
10e8d63	sage.features.sagemath: Use JoinFeature when tag is different from the actually tested module
654d09c	sage.features.sagemath: Change sage_optional_tags to sage_features
f63a7d0	src/sage/features/: Move features depending on optional packages to separate files
c764c7a	Merge #32614
add89fa	src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Mark doctests using combinatorial polytopes # optional - sage.combinat or # optional - sage.rings.number_field
a307e92	src/sage/geometry/polyhedron/combinatorial_polyhedron/conversions.pyx: Mark doctests # optional - sage.combinat

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bc62348

src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Add some missing # optional - sage.combinat

[sagetrac-git]

Changed commit from a307e92 to bc62348

[kliem]

comment:5

+            sage: P = polytopes.permutahedron(5)                                # optional - sage.rings.number_field
+            sage: C = CombinatorialPolyhedron(P)                                # optional - sage.rings.number_field
+            sage: it = C.face_iter(dimension=2)                                 # optional - sage.rings.number_field
+            sage: face = next(it); face                                         # optional - sage.rings.number_field
             A 2-dimensional face of a 4-dimensional combinatorial polyhedron
-            sage: face.ambient_Vrepresentation()
+            sage: face.ambient_Vrepresentation()                                # optional - sage.rings.number_field
             (A vertex at (1, 3, 2, 5, 4),
              A vertex at (2, 3, 1, 5, 4),
              A vertex at (3, 1, 2, 5, 4),
              A vertex at (3, 2, 1, 5, 4),
              A vertex at (2, 1, 3, 5, 4),
              A vertex at (1, 2, 3, 5, 4))
-            sage: face = next(it); face
+            sage: face = next(it); face                                         # optional - sage.rings.number_field
             A 2-dimensional face of a 4-dimensional combinatorial polyhedron
-            sage: face.ambient_Vrepresentation()
+            sage: face.ambient_Vrepresentation()                                # optional - sage.rings.number_field
             (A vertex at (2, 1, 4, 5, 3),
              A vertex at (3, 2, 4, 5, 1),
              A vertex at (3, 1, 4, 5, 2),
              A vertex at (1, 3, 4, 5, 2),
              A vertex at (1, 2, 4, 5, 3),
              A vertex at (2, 3, 4, 5, 1))
-            sage: face.ambient_Hrepresentation()
+            sage: face.ambient_Hrepresentation()                                # optional - sage.rings.number_field
             (An inequality (0, 0, -1, -1, 0) x + 9 >= 0,
              An inequality (0, 0, 0, -1, 0) x + 5 >= 0,
              An equation (1, 1, 1, 1, 1) x - 15 == 0)
-            sage: face.ambient_H_indices()
+            sage: face.ambient_H_indices()                                      # optional - sage.rings.number_field
             (25, 29, 30)
-            sage: face = next(it); face
+            sage: face = next(it); face                                         # optional - sage.rings.number_field
             A 2-dimensional face of a 4-dimensional combinatorial polyhedron
-            sage: face.ambient_H_indices()
+            sage: face.ambient_H_indices()                                      # optional - sage.rings.number_field
             (24, 29, 30)
-            sage: face.ambient_V_indices()
+            sage: face.ambient_V_indices()                                      # optional - sage.rings.number_field

Is this correct?

[kliem]

Reviewer: Jonathan Kliem

[mkoeppe]

comment:7

No, I'll have to fix this one - a lapse of concentration

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cf86501

src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Fix some # optional

[sagetrac-git]

Changed commit from bc62348 to cf86501

[kliem]

comment:9

There is one example in src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx that should have went into #32652.

You can either fix it or leave it as it is. Either way, you can put it on positive review on my behalf.

[mkoeppe]

comment:10

let's just keep it here - thanks!

[sagetrac-git]

Changed commit from cf86501 to 3acc6a9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

4558791	Merge tag '9.5.beta3' into t/32614/features_and_optional_tags_for_sage_subset_distributions
3acc6a9	Merge #32614

[vbraun]

Changed branch from u/mkoeppe/sage_geometry_polyhedron__mark_doctests___optional___sage_combinat to 3acc6a9