Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Expression from sage.structure.element #32730

Closed
mkoeppe opened this issue Oct 20, 2021 · 10 comments
Closed

Import Expression from sage.structure.element #32730

mkoeppe opened this issue Oct 20, 2021 · 10 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 20, 2021

... outside of sage.symbolic, sage.functions, etc.

Follow-up on #32638, which added the ABC sage.structure.element.Expression

CC: @kliem @kwankyu

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: e13b958

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32730

@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 20, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2021

New commits:

16a74e2For isinstance tests, import Expression from sage.structure.element
e13b958src/sage/plot: Import Expression from sage.structure.element

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2021

Commit: e13b958

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2021

comment:3

The failure in src/sage/rings/integer.pyx is not from this ticket.

@kliem
Copy link
Contributor

kliem commented Oct 28, 2021

comment:5

LGTM.

@kliem
Copy link
Contributor

kliem commented Oct 28, 2021

Reviewer: Jonathan Kliem

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 28, 2021

comment:6

Thank you!

@vbraun
Copy link
Member

vbraun commented Oct 31, 2021

@vbraun vbraun closed this as completed in 0986d36 Oct 31, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants