Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.categories.coxeter_groups: Remove module-level imports from sage.rings, sage.graphs #32769

Closed
mkoeppe opened this issue Oct 25, 2021 · 7 comments
Closed

sage.categories.coxeter_groups: Remove module-level imports from sage.rings, sage.graphs #32769

mkoeppe opened this issue Oct 25, 2021 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 25, 2021

(cherry-picked from #32432)

CC: @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 86aec73

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32769
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 25, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2021

Branch: u/mkoeppe/sage_categories_coxeter_groups__remove_module_level_imports_from_sage_rings__sage_graphs

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2021

Commit: 86aec73

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2021

New commits:

4d53db6src/sage/categories/coxeter_groups.py: Remove module-level import from sage.graphs
86aec73src/sage/categories/coxeter_groups.py: Move import of ZZ into method

@tscrim
Copy link
Collaborator

tscrim commented Oct 25, 2021

comment:3

Green bot => positive review.

@tscrim
Copy link
Collaborator

tscrim commented Oct 25, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

comment:4

Thank you!

The only failure, in src/sage/rings/integer.pyx, is not from this ticket.

@vbraun
Copy link
Member

vbraun commented Oct 31, 2021

Changed branch from u/mkoeppe/sage_categories_coxeter_groups__remove_module_level_imports_from_sage_rings__sage_graphs to 86aec73

@vbraun vbraun closed this as completed in 7e8ac9f Oct 31, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#32769
2788e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe