Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split convex set methods of polyhedra into base1.py #32776

Closed
kliem opened this issue Oct 26, 2021 · 18 comments
Closed

split convex set methods of polyhedra into base1.py #32776

kliem opened this issue Oct 26, 2021 · 18 comments

Comments

@kliem
Copy link
Contributor

kliem commented Oct 26, 2021

Part of #32651.

Outsource convex set methods of polyhedra, but not those that construct new polyhedra.

Depends on #32767
Depends on #32731
Depends on #32630

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 6c79ebe

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32776

@kliem kliem added this to the sage-9.5 milestone Oct 26, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 26, 2021

Changed dependencies from #32767 to #32767, #32731

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 26, 2021

Changed branch from u/gh-kliem/polyhedron_base1 to u/mkoeppe/polyhedron_base1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Changed commit from f0121c5 to 36c5980

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

36c5980Merge #32731

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Changed commit from 36c5980 to 6abf489

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6abf489Merge #32731

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

315748csrc/sage/geometry/abc.pyx: Update unique direct subclass test for ABC Polyhedron

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Changed commit from 6abf489 to 315748c

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 26, 2021

Changed dependencies from #32767, #32731 to #32767, #32731, #32630

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c2e0df8replaced "as far as" by "if"
15f2086Removed import of deprecated_function_alias (imported but unused according to pyflakes)
cd46b36Merge #32630
2bb33dcsrc/sage/geometry/abc.pyx: Update unique direct subclass test for ABC Polyhedron (fixup)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Changed commit from 315748c to 2bb33dc

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 26, 2021

comment:9

Merged some tickets to avoid merge conflicts later on.

LGTM, thanks for working on this!

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 26, 2021

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor Author

kliem commented Oct 26, 2021

comment:10

Thank you.

Well, this whole overly large file has always been annoying me. At some point I wanted to optimize polyhedral constructions and it is really difficult to locate them all (ok there is quickref).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2021

Changed commit from 2bb33dc to 6c79ebe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

6c79ebeMerge tag '9.5.beta5' into t/32776/polyhedron_base1

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 29, 2021

comment:12

trivial merge

@vbraun
Copy link
Member

vbraun commented Oct 31, 2021

Changed branch from u/mkoeppe/polyhedron_base1 to 6c79ebe

@vbraun vbraun closed this as completed in a35e2c5 Oct 31, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants