Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more void packages to distros/void.txt #33098

Closed
tornaria opened this issue Dec 30, 2021 · 13 comments
Closed

Add more void packages to distros/void.txt #33098

tornaria opened this issue Dec 30, 2021 · 13 comments

Comments

@tornaria
Copy link
Contributor

CC: @orlitzky

Component: distribution

Author: Gonzalo Tornaría

Branch/Commit: c44fe9b

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33098

@tornaria tornaria added this to the sage-9.5 milestone Dec 30, 2021
@tornaria
Copy link
Contributor Author

Author: Gonzalo Tornaría

@tornaria
Copy link
Contributor Author

Branch: u/tornaria/void-packages

@tornaria
Copy link
Contributor Author

Commit: 7f5f2ff

@tornaria
Copy link
Contributor Author

New commits:

a3b730bvoid linux: packages that can be used from system
986b7c6void linux: add python3 packages for #29665
d267273void linux: more standard python3 packages
6804df2void linux: more optional python3 packages
7f5f2ffvoid linux: add more optional and experimental packages

@orlitzky
Copy link
Contributor

comment:2

Do we have a github (tox) job for Void yet? I'm happy to rubber-stamp this for you if there's no risk of it breaking the CI.

@tornaria
Copy link
Contributor Author

comment:3

Replying to @orlitzky:

Do we have a github (tox) job for Void yet? I'm happy to rubber-stamp this for you if there's no risk of it breaking the CI.

I haven't paid much attention to tox yet, but there is #33084 and I'll try to look at that. My template for building sage on void knows which dependencies to install so it's not like we need it; this is more to help someone wanting to build from source on void so the suggestion on which packages to install is correct and complete.

We have void-linux/void-packages#34030 which is building and testing sage; it is using all the packages I added in the first commit (including linbox and maxima via patches taken from #29631 and #32867)

All tests pass in our standard architectures (x86_64, x86_64-musl and i686) using all possible system packages with system python 3.10 (using #30766) and assorted patches needed for doctests to pass (right now github shows a failure on i686 but that's just the timeout reported in #33091; I added a patch to solve that but I didn't push yet to gh).

Of the remaining tickets, only the second one should have any effect and only after patching with #29665 (which is my next goal as I want to try to ship sage 9.5 for void using system packages as much as possible).

Anyway, I don't really know how tox uses these package lists, so I may be missing something...

@tornaria
Copy link
Contributor Author

comment:4

I already found at least one error while trying #29665 (python3-ipython_ipywidgets should be python3-jupyter_ipywidgets).

Let's hold this until I finish testing #29665.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2021

Changed commit from 7f5f2ff to c44fe9b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cf12322void linux: add python3 packages for #29665
90e1be7void linux: more standard python3 packages
5d8c6a0void linux: more optional python3 packages
c44fe9bvoid linux: add more optional and experimental packages

@tornaria
Copy link
Contributor Author

comment:6

Added the fix mentioned above and added some more packages due to updated #29665.

I've now tested everything with #29665 and all possible system site packages.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 31, 2021

Reviewer: Matthias Koeppe

@slel
Copy link
Member

slel commented Jan 30, 2022

comment:8

Setting milestone to 9.6 now that 9.5 is out.

@slel slel modified the milestones: sage-9.5, sage-9.6 Jan 30, 2022
@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from u/tornaria/void-packages to c44fe9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants