-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pictures to point.py documentation #33124
Comments
Commit: |
New commits:
|
Author: Javier Honrubia González |
comment:6
How about editing spaces in the examples while we are at it? |
Reviewer: Kwankyu Lee |
comment:10
Replying to @kwankyu:
Can you give me a hint on what I have to look for? I don't think I get what are you refering to.
|
comment:11
I guess I meant --- a/src/sage/plot/point.py
+++ b/src/sage/plot/point.py
@@ -148,15 +148,15 @@ class Point(GraphicPrimitive_xydata):
One point::
- sage: A=point((1,1))
- sage: a=A[0];a
+ sage: A = point((1,1))
+ sage: a = A[0]; a
Point set defined by 1 point(s)
- sage: b=a.plot3d()
+ sage: b = a.plot3d()
.. PLOT::
- A=point((1,1))
- a=A[0]
+ A = point((1,1))
+ a = A[0]
sphinx_plot(a.plot3d())
One point with a height:: There are more of such lines. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Looks good to me. Thank you. |
This comment has been minimized.
This comment has been minimized.
comment:16
Merge failure on top of: 4b99c49 Trac #25688: Inaccuracy in symbolic series result on 32bit Linux 64cca20 Trac #33479: adjust error messages in plot/ 7197367 Trac #33478: more doctests in modules/misc 6fa0bc3 Trac #33476: make "standard_coxeter_elements" work more generally d73b4f4 Trac #33470: provide size of findstat query result fa0c93f Trac #33467: sage.geometry: Use PalpExecutable(...).absolute_filename() b9155bf Trac #33463: Fix some corner and special cases concerning localization of integral domains 48a3b47 Trac #33460: adjust error messages in groups/ 7697092 Trac #33448: opensuse-tumbleweed: More fplll issues 1b9dbfe Trac #33347: Enforce MathJax for every page of Sage documentation 7149a31 Trac #33305: cython: Update to 0.29.28 c0aa17e Trac #33251: polymake: Update to 4.6 d14aae1 Trac #33147: use PARI's ellmul() for elliptic curves over finite fields 0335d07 Trac #33116: Update pillow to 9.0.1 82fba97 Trac #33075: Constant field extension of function fields 950ecf8 Trac #32893: Features for palp, polytopes_db, polytopes_db_4d ed49c68 Trac #32736: LU permutation matrix has the wrong base ring c6092dc Trac #32645: sage.geometry.polyhedron.backend_cdd: Go through sage.features for _cdd_executable 78990d5 Trac #32069: Upgrade jupyterlab to 3.3.x, add "sage -n nbclassic" and "sage -n retrolab" 314d846 Trac #31590: Allow passing command to plantri 6376bce Trac #31296: sage.features.Executable: Prepend $SAGE_VENV/bin:$SAGE_LOCAL/bin to PATH 20577cc Trac #31292: sage.features.Executable: Add method absolute_filename 64f765c Trac #27637: Equivariant Ehrhart Theory 6e05da6 Trac #33398: Upgrade SymPy to 1.10 and update doctests f250edf Trac #30767: Update Python to 3.10.x eb21746 Trac #33473: numpy incompatibility when using system python and numpy 1.22 is installed in the system b21ca55 Updated SageMath version to 9.6.beta4 merge was not clean: conflicts in src/sage/plot/point.py |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:19
Conflict fixed. |
comment:20
Usually you are free to set back to positive review after resolving simple merge conflicts. But in this case, let us wait for documentation build. |
comment:21
Still LGTM. |
Changed branch from u/jhonrubia6/add_pictures_point_py_documentation to |
As the title says, we add pictures to point.py documentation.
Component: documentation
Keywords: plot2D
Author: Javier Honrubia González
Branch/Commit:
9fb8b9b
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/33124
The text was updated successfully, but these errors were encountered: