Remove imports from sage.all and sage.rings.all in sage.rings

[mkoeppe]

as found by ./sage -tox -e relint

... except for src/sage/rings/tests.py

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: eecd577

Reviewer: Kwankyu Lee, Guillermo Moreno-Socías

Issue created by migration from https://trac.sagemath.org/ticket/34189

[mkoeppe]

Branch: u/mkoeppe/remove_imports_from_sage_rings_all

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

8431c6c

src/sage/rings: Remove imports from sage.rings.all

[mkoeppe]

Commit: 8431c6c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6df82e3	src/sage/rings/rational_field.py: Remove imports from sage.rings.all
3e420f7	src/sage/rings: Remove remaining imports from sage.rings.all

[sagetrac-git]

Changed commit from 8431c6c to 3e420f7

[sagetrac-git]

Changed commit from 3e420f7 to 635976a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7c732d3	src/sage/rings/number_field/order.py: Incidental pyflakes fix
517980d	src/sage/rings/rational_field.py: Remove two more .all imports
635976a	src/sage/rings/rational_field.py: Remove last .all import

[sagetrac-git]

Changed commit from 635976a to b9893f2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b9893f2

sage.rings: Remove imports from sage.all

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

309726f

sage.rings: Remove imports from sage.all

[sagetrac-git]

Changed commit from b9893f2 to 309726f

[GMS103]

comment:10

In src/sage/rings/quotient_ring.py, should

from sage.all import Infinity

be replaced by

from sage.rings.infinity import Infinity?

(If this is the case, I can look for other instances.)

[mkoeppe]

comment:11

Yes, thanks for catching this. Not sure how it slipped through.

[GMS103]

comment:12

There is also
from sage.rings.all import IntegerModRing
in
src/sage/rings/padics/padic_template_element.pxi

but perhaps this is normal?

[sagetrac-git]

Changed commit from 309726f to 96af429

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

96af429

src/.relint.yml (namespace_pkg_all_import): Check all namespace packages from #33011, also check .pxi files

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5047328	src/sage/rings/quotient_ring.py: Remove .all import
eecd577	src/sage/rings/padics/padic_template_element.pxi: Remove .all import

[sagetrac-git]

Changed commit from 96af429 to eecd577

[mkoeppe]

comment:16

OK, fixed the tooling and fixed these two.

[kwankyu]

comment:17

In

pattern: 'from\s+sage(|[.](arith|categories|combinat|ext|graphs(|[.]decompositions)|interfaces|libs|matrix|misc|numerical(|[.]backends)|rings|sets))[.]all\s+import'

is the final . before all really optional?

The namespace package hierarchy is hardcoded into this pattern. Thus the pattern would need constant updating as the hierarchy evolves. Perhaps we need a central source of the namespace package hierarchy and this pattern could be constructed from the source. No?

[mkoeppe]

comment:18

Replying to @kwankyu:

In

pattern: 'from\s+sage(|[.](arith|categories|combinat|ext|graphs(|[.]decompositions)|interfaces|libs|matrix|misc|numerical(|[.]backends)|rings|sets))[.]all\s+import'

is the final . before all really optional?

These patterns are regular expressions. Square brackets are character sets, not optional items. [.] accepts the literal character . only

[mkoeppe]

comment:19

Replying to @kwankyu:

Thus the pattern would need constant updating as the hierarchy evolves. Perhaps we need a central source of the namespace package hierarchy and this pattern could be constructed from the source.

In #34201, I mention a more semantic code analysis tool that could perhaps be used instead of this simple regular expression based check. But for now I'd like to keep this as simple as possible

[kwankyu]

comment:20

Replying to @mkoeppe:

Replying to @kwankyu:

In

pattern: 'from\s+sage(|[.](arith|categories|combinat|ext|graphs(|[.]decompositions)|interfaces|libs|matrix|misc|numerical(|[.]backends)|rings|sets))[.]all\s+import'

is the final . before all really optional?

These patterns are regular expressions. Square brackets are character sets, not optional items. [.] accepts the literal character . only

Right. I misunderstood.

[kwankyu]

comment:21

Replying to @mkoeppe:

In #34201, I mention a more semantic code analysis tool that could perhaps be used instead of this simple regular expression based check. But for now I'd like to keep this as simple as possible

Okay.

Then I am positive with this ticket.

[kwankyu]

Reviewer: Kwankyu Lee, ...

[GMS103]

comment:22

Then I am positive with this ticket.

Me too.

[kwankyu]

Changed reviewer from Kwankyu Lee, ... to Kwankyu Lee, Guillermo Moreno-Socías

[mkoeppe]

comment:24

Thanks both!

[vbraun]

Changed branch from u/mkoeppe/remove_imports_from_sage_rings_all to eecd577