-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.{rings,modules,geometry}: Replace imports from sage.*.all for namespace packages #34947
Comments
New commits:
|
Commit: |
Reviewer: tscrim, vdelecroix |
This comment has been minimized.
This comment has been minimized.
Changed reviewer from tscrim, vdelecroix to none |
comment:5
Lint and Build&Test failures are unrelated. |
comment:7
One essentially trivial thing: -from sage.arith.misc import factor
-from sage.arith.misc import primitive_root
-from sage.arith.misc import CRT_basis
+from sage.arith.misc import factor, primitive_root, CRT_basis (I am not a fan of the |
Reviewer: Travis Scrimshaw |
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Matthias Koeppe |
comment:10
Thanks. |
comment:11
Thanks, Travis! |
….*.all for namespace packages Using `./sage -fiximports` from #34945. Also remove trailing whitespace in the affected files. Part of Meta-ticket #32414 URL: https://trac.sagemath.org/34947 Reported by: mkoeppe Ticket author(s): Alex Chandler Reviewer(s): Travis Scrimshaw, Matthias Koeppe
Merged in 10.0.beta0 |
Using
./sage -fiximports
from #34945.Also remove trailing whitespace in the affected files.
Part of Meta-ticket #34201
CC: @alexchandler100 @tscrim @videlec
Component: refactoring
Author: Alex Chandler
Branch/Commit: u/mkoeppe/sage__rings_modules_geometry___replace_imports_from_sage___all_for_namespace_packages @
9a212f4
Reviewer: Travis Scrimshaw, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/34947
The text was updated successfully, but these errors were encountered: