Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.graphs: Replace imports from sage.*.all for namespace packages #34952

Closed
mkoeppe opened this issue Jan 29, 2023 · 6 comments
Closed

sage.graphs: Replace imports from sage.*.all for namespace packages #34952

mkoeppe opened this issue Jan 29, 2023 · 6 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023 •
edited
Loading

Using ./sage -fiximports from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #34201

CC: @alexchandler100 @dcoudert @dimpase

Component: refactoring

Author: Alex Chandler

Branch/Commit: u/mkoeppe/sage_graphs__replace_imports_from_sage___all_for_namespace_packages @ 180c16b

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34952
@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 29, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Branch: u/mkoeppe/sage_graphs__replace_imports_from_sage___all_for_namespace_packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

New commits:

180c16bsage -fiximports src/sage/graphs

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Commit: 180c16b

@dcoudert
Copy link
Contributor

comment:3

LGTM.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#34952
7993cfc
vbraun pushed a commit that referenced this issue Feb 12, 2023
Trac #34952: sage.graphs: Replace imports from sage.*.all for namespa…
3095f51 
…ce packages

Using `./sage -fiximports` from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #32414

URL: https://trac.sagemath.org/34952
Reported by: mkoeppe
Ticket author(s): Alex Chandler
Reviewer(s): David Coudert
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Merged in 10.0.beta0

@mkoeppe mkoeppe closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

No branches or pull requests
2 participants
@mkoeppe @dcoudert