Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.{misc,monoids,sets}: Replace imports from sage.*.all for namespace packages #34956

Closed
mkoeppe opened this issue Jan 29, 2023 · 15 comments
Closed

sage.{misc,monoids,sets}: Replace imports from sage.*.all for namespace packages #34956

mkoeppe opened this issue Jan 29, 2023 · 15 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023 •
edited
Loading

Using ./sage -fiximports from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #34201

CC: @alexchandler100 @tscrim

Component: refactoring

Author: Alex Chandler, Matthias Koeppe

Branch/Commit: u/mkoeppe/sage__misc_monoids_sets___replace_imports_from_sage___all_for_namespace_packages @ a8a3d6e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34956
@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 29, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Branch: u/mkoeppe/sage__misc_monoids_sets___replace_imports_from_sage___all_for_namespace_packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Commit: ecdec6b

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

New commits:

b56aaaesage -fiximports src/sage/{misc,monoids,sets}
ecdec6bsrc/sage/misc/lazy_import.pyx: Do not use .all imports as examples in doctests

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Changed author from Alex Chandler to Alex Chandler, Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

comment:3
sage -t --random-seed=177204116540218245270635058655148957979 sage/misc/lazy_import.pyx  # 12 doctests failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

d1ca407src/sage/misc/lazy_import.pyx: Fix doctest
af823ccsrc/sage/misc/lazy_import.pyx: Fix doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from ecdec6b to af823cc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from af823cc to 16efed0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

16efed0src/sage/misc/sage_eval.py: Fix markup

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from 16efed0 to a8a3d6e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

39b7ca4src/sage/env.py: Hide a legitimate .all import from relint
a8a3d6esrc/sage/tests/startup.py: Hide a legitimate .all import from relint

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 30, 2023
@tscrim
Copy link
Collaborator

tscrim commented Jan 30, 2023

comment:9

LGTM.

@tscrim tscrim modified the milestones: sage-9.9, sage-9.8 Jan 30, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

comment:11

Thanks!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

Reviewer: Travis Scrimshaw

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#34956
63a433f
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#34956
22fa718
vbraun pushed a commit that referenced this issue Feb 12, 2023
Trac #34956: sage.{misc,monoids,sets}: Replace imports from sage.*.al…
9cf6aa1 
…l for namespace packages

Using `./sage -fiximports` from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #32414

URL: https://trac.sagemath.org/34956
Reported by: mkoeppe
Ticket author(s): Alex Chandler, Matthias Koeppe
Reviewer(s): Travis Scrimshaw
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Merged in 10.0.beta0

@mkoeppe mkoeppe closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

No branches or pull requests
2 participants
@tscrim @mkoeppe