Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message for nonexistent published page more informative #6069

Closed
sagetrac-khorton mannequin opened this issue May 18, 2009 · 13 comments
Closed

Make error message for nonexistent published page more informative #6069

sagetrac-khorton mannequin opened this issue May 18, 2009 · 13 comments

Comments

@sagetrac-khorton
Copy link
Mannequin

sagetrac-khorton mannequin commented May 18, 2009

If someone attempts to access a URL for a published worksheet that no longer exists (perhaps because the URL changed when the worksheet went through a published to unpublished to published cycle), or the URL was mistyped, they get a blank page titled "Error | Sage Notebook", with no hint on what to do to resolve the problem.

If they are trying to access a published worksheet that cannot be found, it is probably useful to redirect to the page with the list of published worksheets, perhaps after showing an error message like "There is no worksheet currently available at this URL. You will be redirected to the index of published worksheets in 15 seconds."

This may be related to ticket 5988:

#5988

CC: @sagetrac-acleone @robert-marik

Component: notebook

Author: Tim Dumol, Mitesh Patel

Reviewer: Tim Dumol, Mitesh Patel

Merged: sagenb-0.8

Issue created by migration from https://trac.sagemath.org/ticket/6069

@TimDumol TimDumol mannequin changed the title Blank notebook page when loading URL for published sheet that is AWOL Make error message for nonexistent published page more informative Jan 18, 2010
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

Attachment: trac_6069-missing-published-worksheet.patch.gz

This says that "There is no published worksheet with name '%s'" instead.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

comment:2

I think the previous message "The user 'pub' has no worksheet '%s'" was a bit confusing, but it does work. Feel free to ignore the patch and close this.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

Author: Tim Dumol

@TimDumol TimDumol mannequin added the s: needs review label Jan 18, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

Redirect to pub/ after delay. Apply only this patch. sagenb repo.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

comment:3

Attachment: trac_6069-missing_pub_ws.2.patch.gz

V2 is an attempt to set up redirection. It should also ensure for guest users that the error page does not include the full top bar (Settings, Log, etc.).

Feel free to make changes.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

comment:4

V2 applies cleanly to #8051 + #7784 + #5712.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 14, 2010

Better titles for non-Error pages. Apply only this patch.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 14, 2010

comment:5

Attachment: trac_6069-missing_pub_ws.3.patch.gz

V3 should

  • Fix Data file deletion in notebook throws errors #8234.
  • Use a title more appropriate than Error for certain non-Error pages (see the patch).
  • Make "Sign Out" redirect to "/" when require_login=False. This is better than returning a page whose header refers to a user named "None" and has a broken "Home" link!

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 14, 2010

Changed author from Tim Dumol to Tim Dumol, Mitesh Patel

@qed777 qed777 mannequin added this to the sage-4.3.3 milestone Feb 14, 2010
@qed777 qed777 mannequin added p: blocker / 1 and removed wishlist item labels Feb 14, 2010
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Mar 12, 2010

comment:7

Patel's changes look great. Anyone mind signing off mine?

@qed777
Copy link
Mannequin

qed777 mannequin commented Mar 12, 2010

Reviewer: Tim Dumol, Mitesh Patel

@jhpalmieri
Copy link
Member

comment:9

(I'm not changing any notebook code in Sage 4.4.)

@jhpalmieri jhpalmieri modified the milestones: sage-4.4, sage-5.0 Apr 23, 2010
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Apr 24, 2010

Merged: sagenb-0.8

@jhpalmieri jhpalmieri modified the milestones: sage-5.0, sage-4.4.1 Apr 27, 2010
@TimDumol TimDumol mannequin removed the s: positive review label May 4, 2010
@TimDumol TimDumol mannequin closed this as completed May 4, 2010
@TimDumol TimDumol mannequin mentioned this issue May 3, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant