Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate taylor() in favor of series() #6119

Open
robertwb opened this issue May 22, 2009 · 14 comments
Open

deprecate taylor() in favor of series() #6119

robertwb opened this issue May 22, 2009 · 14 comments

Comments

@robertwb
Copy link
Contributor

Symbolic expressions have two methods to obtain series expansions. The taylor() method is a wrapper around maxima's taylor command. The result of this is not always a Taylor series, which leads to confusions.

The series() method was introduced in the pynac-based symbolics. ATM, it is a thin wrapper around GiNaC series expansions. This also plays well with the symbolic functions, etc. introduced based on Pynac/GiNaC.

We should deprecate the taylor() method and add an algorith= argument to series(). The default behavior can be to call GiNaC and fall back to maxima if that fails.

Dependencies: pynac-0.7.4

CC: @kcrisman @rwst

Component: calculus

Author: Ralf Stephan

Branch/Commit: u/rws/deprecate_taylor___in_favor_of_series__ @ 46c8e43

Issue created by migration from https://trac.sagemath.org/ticket/6119

@burcin
Copy link

burcin commented Jun 29, 2011

comment:2

From #9555 comment:6:

The taylor() method is cruft left over from pre-pynac symbolics. We should deprecate it in favor of the series() method. It's perfectly acceptable to give Puiseux series as a result of a call to .series(). I expect this to be done in #6119, where we add an algorithm= option to .series(). The default behavior can be to call pynac and fall back to maxima if that returns an error.

In short, we should change this ticket to cover this transition. Series expansions in Pynac need more work to match what maxima does. That should be tracked on the pynac issue tracker:

https://bitbucket.org/burcin/pynac/issues

@burcin

This comment has been minimized.

@burcin burcin changed the title implement taylor series without maxima deprecate taylor() in favor of series() Jun 29, 2011
@burcin burcin modified the milestones: sage-4.7.1, sage-4.7.2 Jun 29, 2011
@kcrisman
Copy link
Member

comment:3

As I say in #9555, I think that changing the .taylor() method so that it calls a suitably Taylor-only version of the .series() method is preferable, especially since the global name taylor() should really be kept.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@kcrisman
Copy link
Member

kcrisman commented Dec 6, 2014

comment:8

See also http://sourceforge.net/p/maxima/bugs/2850/ where this comes up again.

@kcrisman
Copy link
Member

kcrisman commented Dec 8, 2014

comment:9

As I say in #9555, I think that changing the .taylor() method so that it calls a suitably Taylor-only version of the .series() method is preferable, especially since the global name taylor() should really be kept.

And I'm quoted at this SO comment though I still have to think more about how we should solve this.

@rwst
Copy link

rwst commented Jan 18, 2017

@kcrisman
Copy link
Member

comment:11

Is this deprecating or simply replacing? Sorry for being confused.


New commits:

46c8e436119: use fast series in taylor when possible

@kcrisman
Copy link
Member

Commit: 46c8e43

@rwst
Copy link

rwst commented Jan 18, 2017

Author: Ralf Stephan

@rwst
Copy link

rwst commented Jan 18, 2017

comment:12

Too fast. The deprecation part is upcoming. The Maxima replacement depends on a bugfix in upcoming pynac-0.7.4 for one doctest fail.

@rwst
Copy link

rwst commented Jan 18, 2017

Dependencies: pynac-0.7.4

@rwst
Copy link

rwst commented Jan 18, 2017

comment:13

Replying to @kcrisman:

As I say in #9555, I think that changing the .taylor() method so that it calls a suitably Taylor-only version of the .series() method is preferable, especially since the global name taylor() should really be kept.

Just rereading. So maybe we already have finished the ticket? If so, please review.

@kcrisman
Copy link
Member

comment:14

Nah, I think it is better to do some form of deprecation warning rather than a totally silent change, though I think that keeping taylor as giving taylor only would be plausible too.

@rwst
Copy link

rwst commented Jan 18, 2017

comment:15

Maxima is still faster than GiNaC in the cases with irrational coefficients so we will have to use GiNaC/Pynac for both series and taylor only in the rational case.

@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants