GAP purposely unsets CC which screws up Sun Studio build.

[sagetrac-drkirkby]

spkg-install for gap-4.4.10.p12:

echo "*WARNING*: Unsetting CC since that tends to break GAP building"
unset CC
echo "*WARNING*: Unsetting CXX since that tends to break GAP building"
unset CXX

This appears to be done by Michael Abshoff as SPKG.txt shows:

=== gap-4.4.10.p8 (Michael Abshoff, June 16th, 2008) ===
 * unset CC in spkg-install (work around for #2575)

Looking at #2575 I can't help feel there must be a better solution.

---

New spkg: http://boxen.math.washington.edu/home/leif/Sage/spkgs/gap-4.4.12.p7.spkg

md5sum: 3461058e66fd53d6d53f07acccc8d0c7 gap-4.4.12.p7.spkg

gap-4.4.12.p7 (Leif Leonhardy, March 22nd 2012)

• GAP purposely unsets CC which screws up Sun Studio build. #7041: Only unset CC and CXX if really necessary (i.e., if they
  contain spaces, which is what currently would break the build).
• Clean up spkg-install. Some things seem still weird, see comments.
• Added "Special Update/Build Instructions" section above.

CC: @dimpase @ohanar

Component: build

Keywords: gap solaris cc CXX compiler hardcoded hard-coded sd40.5

Author: Leif Leonhardy

Reviewer: R. Andrew Ohana

Merged: sage-5.1.beta3

Issue created by migration from https://trac.sagemath.org/ticket/7041

[ohanar]

comment:2

well, ignore that patch, wrong ticket (sometimes tab browsing hates you)

[nexttime]

comment:3

For the record, the GAP 4.4.12.p6 spkg still unsets these variables, for whatever reason (#2575 and #4161 might shed some light on that).

Hopefully someone will soon upgrade to GAP 4.5, which might solve potential issues with not unsetting them; haven't tested that (or looked at it) at all.

[nexttime]

Changed keywords from gap solaris cc to gap solaris cc CXX compiler hardcoded hard-coded

[nexttime]

comment:4

I'm currently preparing a GAP 4.4.12.p7 spkg fixing this issue (i.e., only unsetting CC and CXX if absolutely necessary), and cleaning up SPKG.txt and spkg-install.

There are still some open questions though; see e.g. my comments here (on #10825).

[dimpase]

comment:5

Replying to @nexttime:

There are still some open questions though; see e.g. my comments here (on #10825).

I think what you did on #10825 is good.

[nexttime]

Author: Leif Leonhardy

[nexttime]

comment:6

Excerpt from (the modified) SPKG.txt:

Dependencies

• readline (according to spkg/standard/deps)
• Sage (? also according to deps, "so that gap_reset_workspace works")

Special !Update/Build Instructions

• TODO:

  • Use patch instead of copying patched files.
    (Then also add patch to the dependencies above.)
  • "Flatten" (i.e. remove) the build() function.
  • Perhaps check whether we can fix GAP's configure / build scripts
    w.r.t. brokenness of multiple words in CC (and CXX?) and its
    ignorance concerning CFLAGS, CPPFLAGS and LDFLAGS.
    (Then also support SAGE_DEBUG in spkg-install, and probably
    set up reasonable default CFLAGS.)

• Do we really want to copy everything from the build directory???
  (Cf. comment in spkg-install.)

...

I'll perhaps address some of the TODOs (I added myself) later, in a p8, but I'd really like to get this spkg in soon.

The stated (probably obsolete?) dependency on Sage and the last point should be answered by some of you... ;-)

[nexttime]

Attachment: gap-4.4.12.p6-p7.diff.gz

Diff between the previous spkg in Sage and my new p7 spkg. For reference / review only.

[nexttime]

comment:7

As usual, I've attached a diff of the spkg for easier reviewing.

[ohanar]

Reviewer: R. Andrew Ohana

[ohanar]

comment:8

Looks good and works well.

[ohanar]

Changed keywords from gap solaris cc CXX compiler hardcoded hard-coded to gap solaris cc CXX compiler hardcoded hard-coded sd40.5

[jdemeyer]

Merged: sage-5.1.beta3