-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix doctests to support numpy 1.24 #34994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #34994 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.02%
===========================================
Files 2140 2140
Lines 396961 396958 -3
===========================================
- Hits 351695 351651 -44
- Misses 45266 45307 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
40f2e54
to
94cf96a
Compare
I don't know what is the merge conflict. Just in case, I rebased the two (quite small) commits on top of the current In fact the PR was saying I wanted to merge a lot of commits making changes to a lot of files, but I only want to merge 2 commits changing 4 files in minimal ways. |
The merge conflict was against Volker's branch. I had fixed the conflict already by merging #35015. |
I see. Two comments: The problem here is that once a very intrusive PR like #35015 is merged, we are all in the dark until that actually shows up in the |
Undefined values would get some random color. Rreplace all undefined values by white. In numpy 1.24 this avoids a runtime warning (cast of nan to uint8).
Rebased to 10.0.beta1, now it should be ok. |
Documentation preview for this PR is ready! 🎉 |
Taken from #34816.
This is necessary when system numpy is 1.24, and a prerequiste to update numpy in sagemath.
It's probably safer at this time to merge this and leave the update for next release.
Testing: void-linux/void-packages#42048
Depends on #35015