-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.env.sage_include_directories
: Don't use distutils
and SAGE_LIB
#35118
Conversation
Cool to be asked to review this. I will do some basic testing here to make sure it all works for me. But I will be very happy to have this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that it builds properly and the concerned tests pass. I am satisfied with this.
Thank you! |
Documentation preview for this PR is ready! π |
Codecov ReportBase: 88.58% // Head: 88.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35118 +/- ##
========================================
Coverage 88.58% 88.58%
========================================
Files 2140 2140
Lines 396961 396963 +2
========================================
+ Hits 351655 351668 +13
+ Misses 45306 45295 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
π Description
Fixes #33137
π Checklist
β Dependencies