Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.env.sage_include_directories: Don't use distutils and SAGE_LIB #35118

Merged
merged 3 commits into from
Mar 26, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 13, 2023

πŸ“š Description

Fixes #33137

πŸ“ Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 13, 2023
@mkoeppe mkoeppe requested a review from kiwifb February 13, 2023 21:07
@kiwifb
Copy link
Member

kiwifb commented Feb 13, 2023

Cool to be asked to review this. I will do some basic testing here to make sure it all works for me. But I will be very happy to have this in.

Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that it builds properly and the concerned tests pass. I am satisfied with this.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Thank you!

@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: 5ece0c8

@codecov-commenter
Copy link

Codecov Report

Base: 88.58% // Head: 88.58% // Increases project coverage by +0.00% πŸŽ‰

Coverage data is based on head (5ece0c8) compared to base (293dd72).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35118   +/-   ##
========================================
  Coverage    88.58%   88.58%           
========================================
  Files         2140     2140           
  Lines       396961   396963    +2     
========================================
+ Hits        351655   351668   +13     
+ Misses       45306    45295   -11     
Impacted Files Coverage Ξ”
src/sage/env.py 88.10% <100.00%> (+0.10%) ⬆️
src/sage/categories/super_modules_with_basis.py 96.29% <0.00%> (-3.71%) ⬇️
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
...rc/sage/categories/super_lie_conformal_algebras.py 95.00% <0.00%> (-1.67%) ⬇️
src/sage/combinat/combination.py 93.50% <0.00%> (-1.50%) ⬇️
src/sage/cpython/_py2_random.py 75.20% <0.00%> (-0.83%) ⬇️
src/sage/graphs/generic_graph.py 89.12% <0.00%> (-0.40%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
src/sage/combinat/posets/poset_examples.py 88.39% <0.00%> (-0.29%) ⬇️
src/sage/rings/number_field/S_unit_solver.py 83.19% <0.00%> (-0.25%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@vbraun vbraun merged commit e6be37b into sagemath:develop Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sage.env.sage_include_directories: Don't use distutils and SAGE_LIB
5 participants