Make tensor of CombinatorialFreeModule use cartesian_product, deprecate CartesianProduct_iters
#35282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35282 +/- ##
===========================================
- Coverage 88.62% 88.55% -0.07%
===========================================
Files 2148 2148
Lines 398653 398683 +30
===========================================
- Hits 353308 353071 -237
- Misses 45345 45612 +267
... and 38 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mkoeppe
force-pushed
the
t/19195/public/19195
branch
from
3cf1e3a to
e66c2fa
Compare
mkoeppe
force-pushed
the
t/19195/public/19195
branch
from
e66c2fa to
dd9af12
Compare
|
Documentation preview for this PR (built with commit 9b9e276; changes) is ready! 🎉 |
mkoeppe
force-pushed
the
t/19195/public/19195
branch
from
6e077cc to
7e56fac
Compare
added 20 commits
May 26, 2024 18:47
…e possibly infinite set of keys
…hen a factor is an EnumeratedSetFromIterator
…sets are finite; add tests
…ation through new class WithPicklingByInitArgs
…n-UniqueRepresentation case (mockup)
… new class CartesianProduct_base
… new class CartesianProduct_with_element_wrapper
…plementation classes CartesianProduct_eq_by_factors, CartesianProduct_unique
… blame -w --date=format:%Y FILE | sort -k2
added 5 commits
May 26, 2024 18:47
… -> CartesianProduct_unique
…er().__init__ by direct calls
mkoeppe
force-pushed
the
t/19195/public/19195
branch
from
7e56fac to
9b9e276
Compare
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
…WithPicklingByInitArgs`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
- Preparation for sagemath#35282, from where it has been split out.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38097
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
…WithPicklingByInitArgs`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
- Preparation for sagemath#35282, from where it has been split out.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38097
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 17, 2024
…WithPicklingByInitArgs`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
- Preparation for sagemath#35282, from where it has been split out.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38097
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Fixes #19195
📝 Checklist
⌛ Dependencies
CachedRepresentationthrough new classWithPicklingByInitArgs#38097 (split out from here)