Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libatomic_ops: Update to 7.8.0 #35399

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

ivmai
Copy link
Contributor

@ivmai ivmai commented Mar 30, 2023

📚 Description

This is an update to the latest stable release of libatomic_ops.
I'm the upstream maintainer of the package.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 30, 2023

@ivmai welcome here, and thanks!
Our automatic tests won't build the package, but you can run our full portability test suite by enabling GH Actions in your github fork of sage and then pushing a tag.

@ivmai
Copy link
Contributor Author

ivmai commented Mar 31, 2023

@ivmai welcome here, and thanks! Our automatic tests won't build the package, but you can run our full portability test suite by enabling GH Actions in your github fork of sage and then pushing a tag.

Hello @mkoeppe,
Okay, I will run the full test suite but I see that documentation building is failed but I can't see the details. Could you please advise me how to fix the build?

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 31, 2023

I see that documentation building is failed but I can't see the details

These are bugs in our CI, unrelated to your change

@ivmai
Copy link
Contributor Author

ivmai commented Apr 5, 2023

Our automatic tests won't build the package, but you can run our full portability test suite by enabling GH Actions in your github fork of sage and then pushing a tag.

If I understood correctly, I did it: https://github.com/ivmai/sagemath-sage/actions/runs/4572075412 - success
Do I need to check anything else?

@ivmai
Copy link
Contributor Author

ivmai commented May 23, 2023

Colleagues, could you explain me why merging is blocked?
Thank you

@dimpase dimpase force-pushed the update-libatomic_ops-7_8_0 branch from 15f3e24 to 518353b Compare June 14, 2023 09:41
@github-actions
Copy link

Documentation preview for this PR (built with commit 518353b) is ready! 🎉

@dimpase
Copy link
Member

dimpase commented Jun 14, 2023

"merging is blocked" is standard in this repo, as it's the job of the release manager to actually deal with merging positively reviewer PRs into the mainline.

@dimpase
Copy link
Member

dimpase commented Jun 14, 2023

@mkoeppe mkoeppe added this to the sage-10.2 milestone Aug 24, 2023
@vbraun vbraun merged commit fe49240 into sagemath:develop Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants