Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PR build and test workflow for all supported python versions #35481

Closed
wants to merge 2 commits into from

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Apr 11, 2023

📚 Description

The Build & Test workflow should run for all supported Python versions (and not only for the latest supported one) to ensure that all changes in src are compatible with the supported eco system.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 0bbcfbe

@tobiasdiez
Copy link
Contributor Author

@mkoeppe why are these workflows now failing but the corresponding "ci-linux" tests are green? They actually show the same doctest failures, but for some reason this is not taken as a failure. Is this on purpose?

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 11, 2023

Yes, I made it this way on purpose when I wrote the portability infrastructure back in 2020. At that time, so many platforms were broken in the build phase that I wanted to distinguish successful builds from builds in which "just a few doctests are failing".

But I'd be happy to change it now because we are in much better shape regarding platform support and we do want to catch and fix platform-dependent doctest failures.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 11, 2023

This can be done by this change throughout the file:

diff --git a/.github/workflows/ci-linux.yml b/.github/workflows/ci-linux.yml
index aca56f9b49..9f244e7443 100644
--- a/.github/workflows/ci-linux.yml
+++ b/.github/workflows/ci-linux.yml
@@ -52,10 +52,9 @@ jobs:
       free_disk_space: true
       from_docker_repository: ghcr.io/${{ github.repository }}/
       from_docker_target: "with-targets-pre"
-      docker_targets: "with-targets with-targets-optional"
+      docker_targets: "with-targets"
       # FIXME: duplicated from env.TARGETS
-      targets: build doc-html
-      targets_optional: ptest
+      targets: build doc-html ptest
       tox_packages_factors: >-
           ["standard"]
       docker_push_repository: ghcr.io/${{ github.repository }}/

@tobiasdiez
Copy link
Contributor Author

Surpassed by #36373

@tobiasdiez tobiasdiez closed this Oct 1, 2023
@tobiasdiez tobiasdiez deleted the ci_pythons branch October 1, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants