Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/docker.yml: Free more disk space #36418

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 6, 2023

Replacing a step of our docker.yml with a well-maintained action with the same purpose.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 6, 2023

With this version, get:

/dev/root        84G   58G   27G  69% /
tmpfs           3.4G  172K  3.4G   1% /dev/shm
tmpfs           1.4G  1.1M  1.4G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
/dev/sdb1        14G  4.1G  9.0G  31% /mnt
tmpfs           693M   12K  693M   1% /run/user/1001

@mkoeppe mkoeppe force-pushed the ci_disk_space branch 3 times, most recently from 9aaa964 to b16b014 Compare October 7, 2023 00:36
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 7, 2023

Now

/dev/root                     84G   45G   40G  54% /
tmpfs                        3.4G  172K  3.4G   1% /dev/shm
tmpfs                        1.4G  1.1M  1.4G   1% /run
tmpfs                        5.0M     0  5.0M   0% /run/lock
/dev/sdb15                   105M  6.1M   99M   6% /boot/efi
/dev/sda1                     14G   13G  100M 100% /mnt
tmpfs                        693M   12K  693M   1% /run/user/1001
/dev/mapper/buildvg-buildlv   19G   24K   19G   1% /home/runner/work/sage/sage

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 7, 2023

Looks nice.

Where can I see "df -h" in action?

19 gb of the last line is part of 40 gb root space. Right?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 7, 2023

19 gb of the last line is part of 40 gb root space. Right?

No, they are separate

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 7, 2023

Where can I see "df -h" in action?

In "CI Linux Incremental"

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 7, 2023

19 gb of the last line is part of 40 gb root space. Right?

No, they are separate

But this is not a new space the action saved... Is it?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 7, 2023

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 7, 2023

Thanks.

The doc seems to say the 19 gb is a logical volume made up of free spaces of 84 gb / space and 14 gb /mnt space. I am puzzled because the 19 gb is not in #36418 (comment).

Anyway, it's good to use the action dedicated for this business.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 7, 2023

Thanks!

Without my configuration setting root-reserve-mb: 40000, the logical volume (now 19G) would be 58G of free space for /home/runner/work/sage/sage.

@vbraun
Copy link
Member

vbraun commented Oct 8, 2023

merge conflict

@vbraun vbraun merged commit ef7bd8d into sagemath:develop Oct 14, 2023
6 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 14, 2023
@tobiasdiez
Copy link
Contributor

Could it be that this PR is the reason for the out-of-space issues such as https://github.com/sagemath/sage/actions/runs/6529558870/job/17727415989?

@mkoeppe mkoeppe deleted the ci_disk_space branch October 17, 2023 03:54
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 17, 2023

No, it can't. I made this PR when I saw the out of space conditions in some workflow runs about a week ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants