Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Build: Build a docker image incrementally, then test, docbuild, ... in separate jobs #36459

Closed
wants to merge 52 commits into from
Closed

CI Build: Build a docker image incrementally, then test, docbuild, ... in separate jobs #36459

wants to merge 52 commits into from

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 13, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Matthias Koeppe added 30 commits October 9, 2023 12:32
@mkoeppe
build/sage_bootstrap/download/mirror_list.py: Remove sagepad.org
3332a89
@mkoeppe
sage_bootstrap.{tarball, download.mirror_list}: Lower layout of the m…
dd939ff 
…irror to mirror_list
@mkoeppe
sage_bootstrap.download.mirror_list: Delay downloading/reading/rankin…
2dfe081 
…g to first use
@mkoeppe
sage_bootstrap.download.mirror_list: Use master list of download sour…
a37f4fd 
…ces in SAGE_ROOT/.upstream.d
@mkoeppe
src/bin/sage-update-version: Update .upstream.d/20-gh.neting.cc-sagemat…
2323480 
…h-sage-releases
@mkoeppe
sage_bootstrap.download.mirror_list: Skip empty lines earlier
7e65260
@mkoeppe
src/bin/sage-update-version: Also commit
371be50
@mkoeppe
build/bin/write-dockerfile.sh: ADD .upstream.d
423e48a
@mkoeppe
.ci/retrofit-worktree.sh: New, factored out from .github/workflows/bu…
f429993 
…ild*.yml
@mkoeppe
src/tox.ini (pyright): Remove old version pin, do not rely on global …
47f6a98 
…node installation
@mkoeppe
.github/workflows/build.yml: Simplify use of pyright by going through…
47e2783 
… 'sage -tox'
@mkoeppe
Fixup
94c8b88
@mkoeppe
src/tox.ini (pyright): Do not restrict to subdirectories by default
8bf3bcb
@mkoeppe
src/tox.ini (pyright): Pin to 1.1.331 (latest)
81e1afa
@mkoeppe
Rename spkg-piprm-requirements.txt to just spkg-requirements.txt
18458bf
@mkoeppe
build/make/Makefile.in (SCRIPT_PACKAGE_templ): Set more variables set…
4a4810e 
… by sage-spkg
@mkoeppe
build/bin/sage-dist-helpers (sdh_store_[and_pip_install_]wheel): Reco…
952405f 
…rd wheel file name in venv/var/lib/sage/scripts/PKG_BASE/spkg-requirements.txt
@mkoeppe
build/bin/sage-spkg: Remove unused code for packages without spkg-ins…
f8b93c7 
…tall.in
@mkoeppe
build/bin/sage-spkg: Adjust to spkg-requirements.txt being installed …
91b0b83 
…directly
@mkoeppe
build/make/Makefile.in (SCRIPT_PACKAGE_templ): Remove script dir befo…
f91c20b 
…re running spkg-install
@mkoeppe
build/make/Makefile.in (SCRIPT_PACKAGE_templ) [SAGE_CHECK=yes]: Call …
0aaf02e 
…script spkg-postinstcheck if it exists; new target SPKG-check
@mkoeppe
build/pkgs/sagemath_*/spkg-postinstcheck: Break out from spkg-install
417de39
@mkoeppe
Rename spkg-postinstcheck -> spkg-check
3c2939a
@mkoeppe
build/pkgs/sage_sws2rst/spkg-install: Do not call spkg-check from her…
af6d0ad 
…e any more
@mkoeppe
build/make/Makefile.in (pypi-wheels-check): New target
22b101f
@mkoeppe
.github/workflows/build.yml: Separate build and test
3838613
@mkoeppe
.github/workflows/build.yml: Fix 'if' of some steps
8224cb0
@mkoeppe
conda: Do not pin setuptools, instead add legacy editable to install …
e3dce3f 
…instructions
@mkoeppe
build/pkgs/setuptools_wheel: Make distros a symlink too
c60de9a
@mkoeppe
src/doc/en/installation/conda.rst: Restore 'bootstrap' in instruction…
756e5c4 
…s, lost in sagemath#36367
Matthias Koeppe added 14 commits October 12, 2023 09:13
@mkoeppe
pkgs/sage-conf_conda/setup.py: Always run configure
ddbbdc5
@mkoeppe
pkgs/sage-conf_conda/setup.py: Remove 'reusing configured SAGE_ROOT' …
d0cae80 
…message
@mkoeppe
Merge branch 'tox_pyright_update' into ci_streamline
c555723
@mkoeppe
Merge branch 'conda_legacy_editable' into ci_streamline
19f029b
@mkoeppe
Merge branch 'bootstrap_conda_refactor' into ci_streamline
68e9997
@mkoeppe
Merge branch 'gh_actions_release' into ci_streamline
66a8be4
@mkoeppe
Merge branch 'ci_refactor_build' into ci_streamline
2e11b0f
@mkoeppe
build/bin/write-dockerfile.sh, tox.ini (docker-incremental): Make inc…
0bfb487 
…remental build more incremental via git, via git, .ci/retrofit-worktree.sh
@mkoeppe
.github/workflows/build.yml: Merge doc-build.yml, doc-build-pdf.yml
8e25cbd
@mkoeppe
.github/workflows/build.yml: Merge ci-linux-incremental.yml
459da44
@mkoeppe
Merge branch 'wheel_requirements' into ci_streamline_share_build
4e847e3
@mkoeppe
Merge branch 'ci_streamline' into ci_streamline_share_build
c85851e
@mkoeppe
.github/workflows/build.yml: Create image, parallelize modularized tests
30aa592
@mkoeppe
WIP export
8499265
@mkoeppe mkoeppe self-assigned this Oct 13, 2023
@tobiasdiez
Copy link
Contributor

I think using artifacts is a better way to transfer the docker image: https://docs.docker.com/build/ci/github-actions/share-image-jobs/.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 13, 2023

Yes, that's what I'm doing here

@tobiasdiez tobiasdiez mentioned this pull request Oct 16, 2023
Closed
5 tasks
Matthias Koeppe added 2 commits October 16, 2023 21:41
@mkoeppe
Merge tag '10.2.beta7' into ci_streamline_share_build
f158d60 
SageMath version 10.2.beta7, Release Date: 2023-10-14
@mkoeppe
WIP
ad15def
@mkoeppe mkoeppe force-pushed the ci_streamline_share_build branch from d18f2b0 to ad15def Compare October 17, 2023 21:16
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 21, 2023

Closing this, see #36446 (comment)

@mkoeppe mkoeppe closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkoeppe mkoeppe

Labels
c: scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkoeppe @tobiasdiez