-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Linux: Fix centos-7
after #36435, remove gentoo-python3.12
for now, use conda-forge
with -python3.11
#36534
Conversation
centos-7
, remove gentoo-python3.12
for nowcentos-7
after #36435, remove gentoo-python3.12
for now
598c36b
to
1d2231b
Compare
centos-7
after #36435, remove gentoo-python3.12
for nowcentos-7
after #36435, remove gentoo-python3.12
for now, use conda-forge
with -python3.11
Documentation preview for this PR (built with commit 1d2231b; changes) is ready! 🎉 |
I am running Docker Desktop. Is |
No, I use it on macOS. Check using |
Thanks. Solved by checking |
Now stuck at
|
But that seems an issue just with me. Perhaps not related with what's done here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Thank you! |
…ve `gentoo-python3.12` for now, use `conda-forge` with `-python3.11` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> As part of the changes in sagemath#36435, we switched from http to https for downloading mirror_list. This broke centos-7; here we fix it. gentoo-python3.12 was activated a little bit too early. We remove it to clean up the portability CI workflow. conda-forge defaults to 3.12 already, and we're not ready for it. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36534 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
…ve `gentoo-python3.12` for now, use `conda-forge` with `-python3.11` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> As part of the changes in sagemath#36435, we switched from http to https for downloading mirror_list. This broke centos-7; here we fix it. gentoo-python3.12 was activated a little bit too early. We remove it to clean up the portability CI workflow. conda-forge defaults to 3.12 already, and we're not ready for it. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36534 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The fix in sagemath#36534 was not complete. The job was named as intended conda- forge-python3.11, but it was still using 3.12, which failed in https://github.com/sagemath/sage/actions/runs/6827163299/job/18568706581 Fixed here, as tested with `tox -e docker-conda-forge- python3.11-standard -- config.status` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36699 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The fix in sagemath#36534 was not complete. The job was named as intended conda- forge-python3.11, but it was still using 3.12, which failed in https://github.com/sagemath/sage/actions/runs/6827163299/job/18568706581 Fixed here, as tested with `tox -e docker-conda-forge- python3.11-standard -- config.status` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36699 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
As part of the changes in #36435, we switched from http to https for downloading mirror_list.
This broke centos-7; here we fix it.
gentoo-python3.12 was activated a little bit too early. We remove it to clean up the portability CI workflow.
conda-forge defaults to 3.12 already, and we're not ready for it.
📝 Checklist
⌛ Dependencies