Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.manifolds, sage.tensor: Update # needs #36568

Merged
merged 8 commits into from
Nov 5, 2023
Merged

sage.manifolds, sage.tensor: Update # needs #36568

merged 8 commits into from
Nov 5, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 29, 2023 •
edited
Loading

Also some try... except for the sympy imports.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Oct 29, 2023
@mkoeppe mkoeppe requested a review from egourgoulhon October 30, 2023 18:57
@mkoeppe mkoeppe force-pushed the needs_for_sage_manifolds_sage_tensor branch from 3ab41e6 to b9cc9d2 Compare October 31, 2023 01:08
dcoudert
dcoudert suggested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

src/sage/manifolds/point.py Outdated Show resolved Hide resolved
src/sage/manifolds/differentiable/tangent_vector.py Outdated Show resolved Hide resolved
src/sage/manifolds/subsets/pullback.py Outdated
@@ -684,15 +699,15 @@ def __contains__(self, point):
[-1, -1, -1],
[-1, 1, -1],
[-1, 1, 1]]
sage: McCube = ManifoldSubsetPullback(c_cart, Cube, name='McCube'); McCube
sage: McCube = ManifoldSubsetPullback(c_cart, Cube, name='McCube'); McCube # needs sage.geometry.polyhedron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block scope

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All fixed in f3f4416

dcoudert
dcoudert approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 31, 2023

Thank you!

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit f3f4416; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 1, 2023
sagemathgh-36568: sage.manifolds, sage.tensor: Update # needs
6e9fd5b 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Also some `try... except` for the sympy imports.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Cherry picked from sagemath#35095
- Part of sagemath#29705
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36568
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 2, 2023
sagemathgh-36568: sage.manifolds, sage.tensor: Update # needs
104b7dc 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Also some `try... except` for the sympy imports.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Cherry picked from sagemath#35095
- Part of sagemath#29705
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36568
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Matthias Köppe
egourgoulhon
egourgoulhon reviewed Nov 4, 2023
View reviewed changes
src/sage/manifolds/point.py
@@ -871,11 +874,12 @@ def plot(self, chart=None, ambient_coords=None, mapping=None,

The numerical value is used only for the plot::

sage: q.coord()
sage: q.coord() # needs sage.plot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why q.coord() needs sage.plot.

@vbraun vbraun merged commit e5b774d into sagemath:develop Nov 5, 2023
14 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egourgoulhon egourgoulhon egourgoulhon left review comments

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: manifolds t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @egourgoulhon @dcoudert @vbraun