Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace relative imports by absolute ones in sage.libs.ntl #36605

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Replace relative imports by absolute ones in sage.libs.ntl #36605

merged 1 commit into from
Nov 5, 2023

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Oct 31, 2023 •
edited by mkoeppe
Loading

This is for #36228

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez marked this pull request as ready for review October 31, 2023 13:02
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 446f5a2; changes) is ready! 🎉

@mkoeppe mkoeppe changed the title Replace relative imports by absolute ones in ntl Replace relative imports by absolute ones in sage.libs.ntl Oct 31, 2023
@tobiasdiez
Copy link
Contributor Author

Would be nice to get these PRs in as soon as possible to minimize the risk of merge conflicts.

@vbraun vbraun merged commit b655bed into sagemath:develop Nov 5, 2023
16 of 22 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

@tornaria tornaria Awaiting requested review from tornaria

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasdiez @mkoeppe @vbraun