Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.combinat.words: Update # needs #36644

Merged
merged 9 commits into from
Dec 6, 2023
Merged

sage.combinat.words: Update # needs #36644

merged 9 commits into from
Dec 6, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Nov 4, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Nov 4, 2023
dcoudert
dcoudert reviewed Nov 4, 2023
View reviewed changes
src/sage/combinat/words/finite_word.py Outdated Show resolved Hide resolved
src/sage/combinat/words/morphism.py Outdated
@@ -1099,21 +1101,21 @@ def _matrix_(self, R=None):

sage: fibo = WordMorphism('a->ab,b->a')
sage: tm = WordMorphism('a->ab,b->ba')
sage: Mfibo = matrix(fibo); Mfibo # indirect doctest # optional - sage.modules
sage: Mfibo = matrix(fibo); Mfibo # indirect doctest # needs sage.modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block scope

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Documentation preview for this PR (built with commit 8153dbd; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 5, 2023

Thank you!

@vbraun vbraun merged commit bf801b1 into sagemath:develop Dec 6, 2023
21 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels
t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @dcoudert @vbraun