update ECL to 23.9.9, remove obsolete stuff from spkg-install #37044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can the sage install be relocated? I don't know what that spkg-install code was doing and don't really care to investigate since I'll never use the ECL spkg ever again. Otherwise this upgrade is fine, Gentoo has had the new version since it was released. |
|
no, the relocation stuff was gone ages ago |
|
Documentation preview for this PR (built with commit 81cd662; changes) is ready! 🎉 |
|
the removed part of spkg-install does unnecessary (and broken) things with libecl headers, as well. Can I take this as a positive review? |
orlitzky
approved these changes
Jan 12, 2024
|
yep |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
…kg-install
ECL 23.9.9 has been released in Sept 2023, 2.5 years after 21.2.1 we
have.
Time to upgrade.
See the announcement for [ECL](https://ecl.common-
lisp.dev/posts/ECL-2399-release.html)
URL: sagemath#37044
Reported by: Dima Pasechnik
Reviewer(s): Michael Orlitzky
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
…kg-install
ECL 23.9.9 has been released in Sept 2023, 2.5 years after 21.2.1 we
have.
Time to upgrade.
See the announcement for [ECL](https://ecl.common-
lisp.dev/posts/ECL-2399-release.html)
URL: sagemath#37044
Reported by: Dima Pasechnik
Reviewer(s): Michael Orlitzky
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
…kg-install
ECL 23.9.9 has been released in Sept 2023, 2.5 years after 21.2.1 we
have.
Time to upgrade.
See the announcement for [ECL](https://ecl.common-
lisp.dev/posts/ECL-2399-release.html)
URL: sagemath#37044
Reported by: Dima Pasechnik
Reviewer(s): Michael Orlitzky
17 tasks
|
Consider update ECL to version 24.5.10? Should solve #37511. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECL 23.9.9 has been released in Sept 2023, 2.5 years after 21.2.1 we have.
Time to upgrade.
See the announcement for ECL