Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated functions is_Cone, is_Polyhedron, is_LatticePolytope #37057

Merged
merged 6 commits into from
May 2, 2024

Conversation

vamshipy
Copy link
Contributor

<deprecated 3 functions is_Cone, is_Polyhedron, is_LatticePolytope>

< The change will issue a warning when the functions are used that will inform the user about the functions being deprecated and to use a different instead>
<Fixes #34307>

📝 Checklist

  • [x ] The title is concise, informative, and self-explanatory.
  • [ x] The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Jan 14, 2024

Documentation preview for this PR (built with commit 35ff879; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Jan 18, 2024

@mkoeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 8, 2024

This PR is missing the changes from #37052 that rewrite the uses of these newly deprecated functions by isinstance calls. Hence all the doctest failures

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 29, 2024

Cherry-picked from #37052.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green bot => positive review.

@mkoeppe mkoeppe self-assigned this May 1, 2024
@mkoeppe
Copy link
Contributor

mkoeppe commented May 1, 2024

Thanks, Travis! Now it's green.

@vbraun vbraun merged commit 90e08c8 into sagemath:develop May 2, 2024
14 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate is_Polyhedron, is_Cone, is_LatticePolytope
4 participants