Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/sagemath-standard: Remove self-reference at build time #37292

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Feb 11, 2024

As explained in #37287 (comment), we make sagemath-environment a build requirement of pkgs/sagemath-standard.

The monolithic build system in SAGE_ROOT/src is left unchanged.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe force-pushed the sagemath-standard-remove-self-reference branch from 7d39cb3 to 8a09d7c Compare February 14, 2024 00:34
Copy link

Documentation preview for this PR (built with commit 8a09d7c; changes) is ready! 🎉

@tobiasdiez
Copy link
Contributor

With these changes, how do you pip install the monolithic sagelib (ie the one independent of any modularized distributions)?

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 16, 2024

With these changes, how do you pip install the monolithic sagelib

There is no change regarding this.

@tobiasdiez
Copy link
Contributor

With these changes, how do you pip install the monolithic sagelib

There is no change regarding this.

It seems that only pkgs/sagemath-standard is published on pypi, not the one in src. And since you break the smylink it now matters.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 16, 2024

pkgs/sagemath-standard is published on pypi

That's right.

it now matters.

What matters?

@tobiasdiez
Copy link
Contributor

It matters for the following. Right now it is possible to install the monolithic sagelib distribution via pip, with your changes this is no longer possible.

With these changes, how do you pip install the monolithic sagelib

There is no change regarding this.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 19, 2024

Right now it is possible to install the monolithic sagelib distribution via pip, with your changes this is no longer possible.

Nonsense.

@mkoeppe mkoeppe requested a review from kiwifb February 20, 2024 21:41
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2024

@kiwifb Please review

Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It will not change anything from the sdist point of view as far as I can tell. If we are going to split things, I certainly want us to eat our own dog food and see stuff like pyproject-monolithic.toml.m4 going out as quickly as possible.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2024

It will not change anything from the sdist point of view as far as I can tell.

That's right, avoiding the self-ref is just a cleanup.

@tobiasdiez
Copy link
Contributor

Right now it is possible to install the monolithic sagelib distribution via pip, with your changes this is no longer possible.

Nonsense.

You then might want to explain how a user would install it then from pypi (that you can still checkout the code and use the pyproject.toml from src is obvious).

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 21, 2024

#37261 has updated the PyPI install instructions in our README.md, waiting for review.

I'll mark it as a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants