-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgs/sagemath-standard: Remove self-reference at build time #37292
base: develop
Are you sure you want to change the base?
pkgs/sagemath-standard: Remove self-reference at build time #37292
Conversation
…c/pyproject.toml (fixup)
… instead of manipulating sys.path
7d39cb3
to
8a09d7c
Compare
Documentation preview for this PR (built with commit 8a09d7c; changes) is ready! 🎉 |
With these changes, how do you pip install the monolithic sagelib (ie the one independent of any modularized distributions)? |
There is no change regarding this. |
It seems that only pkgs/sagemath-standard is published on pypi, not the one in src. And since you break the smylink it now matters. |
That's right.
What matters? |
It matters for the following. Right now it is possible to install the monolithic sagelib distribution via pip, with your changes this is no longer possible.
|
Nonsense. |
@kiwifb Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It will not change anything from the sdist point of view as far as I can tell. If we are going to split things, I certainly want us to eat our own dog food and see stuff like pyproject-monolithic.toml.m4 going out as quickly as possible.
That's right, avoiding the self-ref is just a cleanup. |
You then might want to explain how a user would install it then from pypi (that you can still checkout the code and use the pyproject.toml from src is obvious). |
#37261 has updated the PyPI install instructions in our README.md, waiting for review. I'll mark it as a dependency |
As explained in #37287 (comment), we make sagemath-environment a build requirement of
pkgs/sagemath-standard
.The monolithic build system in
SAGE_ROOT/src
is left unchanged.📝 Checklist
⌛ Dependencies
README.md
: Improve PyPI install instructions #37261setup.py
: Removelazy_import_cache
use #37432PIP_CONSTRAINT=$SAGE_ROOT/constraints_pkgs.txt
#37434