sage -package dependencies
#37350
Merged
sage -package dependencies
#37350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 14, 2024 19:18
# Conflicts: # build/sage_bootstrap/package.py
|
I get $ sage --package properties furo singular
furo:
path: /Users/kwankyu/GitHub/sage-dev/build/pkgs/furo
version_with_patchlevel: 2022.9.29
type: standard
source: wheel
trees: SAGE_VENV
singular:
path: /Users/kwankyu/GitHub/sage-dev/build/pkgs/singular
version_with_patchlevel: 4.3.2p8
type: standard
source: normal
trees: SAGE_LOCAL
$ sage --package dependencies furo singular
$(MP_LIBRARY)
$(PYTHON)
$(PYTHON_TOOLCHAIN)
beautifulsoup4
cddlib
flint
mpfr
ntl
pygments
readline
sphinx
sphinx_basic_ng
$ sage --package dependencies --format=shell furo singular
order_only_deps_furo='$(PYTHON_TOOLCHAIN) $(PYTHON)'
optional_deps_furo=''
runtime_deps_furo='beautifulsoup4 sphinx pygments sphinx_basic_ng'
check_deps_furo=''
order_only_deps_singular=''
optional_deps_singular=''
runtime_deps_singular='$(MP_LIBRARY) ntl flint readline mpfr cddlib'
check_deps_singular=''It seems that the output of |
mkoeppe
added
s: needs work
s: needs review
and removed
s: needs review
s: needs work
labels
I've made this change and also moved the whole formatting of dependencies for text and RST into sage_bootstrap. |
|
Before After |
kwankyu
reviewed
Feb 20, 2024
Well, the tools in |
|
OK. |
…lain; use in sage-spkg-info
mkoeppe
force-pushed
the
sage_package_dependencies
branch
from
5053453 to
c52a2c4
Compare
|
Because of unnecessary indentation in "Dependencies" section as seen here we have |
|
Thanks! Let's see if I got it right now |
|
Documentation preview for this PR (built with commit cce885f; changes) is ready! 🎉 |
|
It works well. |
|
Thanks for the careful review! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 1, 2024
…nts.txt`
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
As discussed in sagemath#36982:
- the name "install-requires" has become outdated with the transition
to the new names set by the `pyproject.toml` format (see https://setupto
ols.pypa.io/en/latest/userguide/dependency_management.html#declaring-
required-dependency, compare the tabs "pyproject.toml" vs. "setup.cfg")
- this will help with sagemath#35890, as
GitHub will be able to just read the `version_requirements.txt` files
sagemath#36982 (comment)
Notes for reviewers:
- **This is a simple, limited-scope improvement and not intended as a
long-term commitment to the format of the files in build/pkgs/....**
- PRs sagemath#37430, sagemath#37350, sagemath#36740 remove direct access to build/pkgs in favor
of using the sage_bootstrap API (sage --package).
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#37401
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36999
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Kwankyu Lee, Nathan Dunfield
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 8, 2024
…nts.txt`
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
As discussed in sagemath#36982:
- the name "install-requires" has become outdated with the transition
to the new names set by the `pyproject.toml` format (see https://setupto
ols.pypa.io/en/latest/userguide/dependency_management.html#declaring-
required-dependency, compare the tabs "pyproject.toml" vs. "setup.cfg")
- this will help with sagemath#35890, as
GitHub will be able to just read the `version_requirements.txt` files
sagemath#36982 (comment)
Notes for reviewers:
- **This is a simple, limited-scope improvement and not intended as a
long-term commitment to the format of the files in build/pkgs/....**
- PRs sagemath#37430, sagemath#37350, sagemath#36740 remove direct access to build/pkgs in favor
of using the sage_bootstrap API (sage --package).
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#37401
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36999
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Kwankyu Lee, Nathan Dunfield
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new command
sage --package dependencies.Like the command
sage --package propertiesintroduced in #37018, it can be used to eliminate direct references tobuild/pkgs/from various scripts and reduce code duplication in reading SPKG metadata.Here we only make such changes in
sage-spkg-info.The only user-visible change is that the listed dependencies are now sorted alphabetically; this hides subtle nuances that may be expressed in the sort order of some
dependenciesfiles.Split out from:
bootstrap-conda,m4/sage_spkg_collect.m4through sage-package; handledependencies_build#36740📝 Checklist
⌛ Dependencies